Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for tailable cursor with non-capped collection #3677

Merged
merged 22 commits into from
Nov 13, 2023
Merged

Add test for tailable cursor with non-capped collection #3677

merged 22 commits into from
Nov 13, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Nov 3, 2023 •
edited
Loading

Description

Closes #3462.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited
Loading

Codecov Report

Merging #3677 (1e4d356) into main (1f18df0) will decrease coverage by 0.64%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3677      +/-   ##
==========================================
- Coverage   76.81%   76.17%   -0.64%     
==========================================
  Files         323      323              
  Lines       23004    23029      +25     
==========================================
- Hits        17671    17543     -128     
- Misses       4308     4444     +136     
- Partials     1025     1042      +17
Files Coverage Δ
internal/handlers/common/find.go 100.00% <ø> (ø)
internal/handlers/sqlite/msg_find.go 75.00% <84.00%> (-8.71%) ⬇️

... and 18 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 72.20% <84.00%> (-0.70%) ⬇️
hana-1 ?
integration 72.20% <84.00%> (-0.73%) ⬇️
mongodb-1 5.47% <0.00%> (-0.01%) ⬇️
postgresql-1 52.49% <84.00%> (-0.34%) ⬇️
postgresql-2 51.64% <0.00%> (+0.91%) ⬆️
postgresql-3 50.69% <0.00%> (-1.31%) ⬇️
sort-false 72.20% <84.00%> (-0.26%) ⬇️
sort-true ?
sqlite-1 ?
sqlite-2 50.85% <0.00%> (+0.86%) ⬆️
sqlite-3 49.90% <0.00%> (-1.18%) ⬇️
unit 30.08% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup added the code/chore Code maintenance improvements label Nov 6, 2023
@noisersup noisersup marked this pull request as ready for review November 6, 2023 16:47
@noisersup noisersup requested a review from a team as a code owner November 6, 2023 16:47
@noisersup noisersup added this to the Next milestone Nov 6, 2023
@noisersup noisersup requested a review from a team November 6, 2023 16:48
@noisersup noisersup enabled auto-merge (squash) November 6, 2023 16:53
@noisersup noisersup requested a review from rumyantseva November 7, 2023 13:01
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2023

@noisersup this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Nov 8, 2023
AlekSi
AlekSi requested changes Nov 8, 2023
View reviewed changes
integration/query_test.go Outdated Show resolved Hide resolved
@mergify mergify bot removed the conflict PRs that have merge conflicts label Nov 8, 2023
@noisersup noisersup requested a review from AlekSi November 9, 2023 09:26
AlekSi
AlekSi requested changes Nov 10, 2023
View reviewed changes
internal/backends/collection.go Outdated Show resolved Hide resolved
@noisersup noisersup requested a review from AlekSi November 10, 2023 16:06
rumyantseva
rumyantseva approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noisersup noisersup merged commit e4eed05 into FerretDB:main Nov 13, 2023
26 checks passed
@noisersup noisersup deleted the tailable-cursor-3462 branch November 13, 2023 10:22
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Nov 16, 2023
@noisersup @yonarw
Add test for tailable cursor with non-capped collection (FerretDB#3677)
6b8d150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.

Add test for tailable cursor with non-capped collection
3 participants
@noisersup @AlekSi @rumyantseva