Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old SAP HANA handler #3674

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Remove old SAP HANA handler #3674

merged 4 commits into from
Nov 1, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 1, 2023

Description

The new backend is being developed.

Closes #3662.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

The new backend is being developed.
@mergify mergify bot assigned AlekSi Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #3674 (c52c278) into main (b604b6b) will increase coverage by 1.53%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3674      +/-   ##
==========================================
+ Coverage   74.70%   76.23%   +1.53%     
==========================================
  Files         372      321      -51     
  Lines       23626    22950     -676     
==========================================
- Hits        17650    17497     -153     
+ Misses       4961     4421     -540     
- Partials     1015     1032      +17     
Files Coverage Δ
integration/setup/listener.go 80.44% <ø> (-2.38%) ⬇️
integration/setup/setup.go 79.77% <ø> (ø)
internal/handlers/registry/registry.go 43.47% <ø> (ø)
internal/handlers/registry/hana.go 5.26% <0.00%> (-66.17%) ⬇️

... and 14 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 72.24% <0.00%> (+1.46%) ⬆️
hana-1 ?
integration 72.24% <0.00%> (+1.43%) ⬆️
mongodb-1 5.43% <0.00%> (+0.15%) ⬆️
postgresql-1 52.45% <0.00%> (+1.28%) ⬆️
postgresql-2 51.70% <0.00%> (+1.22%) ⬆️
postgresql-3 50.59% <0.00%> (+1.17%) ⬆️
sort-false 72.24% <0.00%> (+1.88%) ⬆️
sort-true ?
sqlite-1 51.78% <0.00%> (+1.02%) ⬆️
sqlite-2 50.97% <0.00%> (+1.21%) ⬆️
sqlite-3 49.83% <0.00%> (+1.24%) ⬆️
unit 29.89% <0.00%> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review November 1, 2023 17:24
@AlekSi AlekSi requested a review from a team as a code owner November 1, 2023 17:24
@AlekSi AlekSi added this to the Next milestone Nov 1, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 1, 2023
@AlekSi AlekSi merged commit c3f7da0 into FerretDB:main Nov 1, 2023
26 of 28 checks passed
@AlekSi AlekSi deleted the remove-old-hana branch November 1, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Move and rename the handler
1 participant