Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention proxy flag in docs #3673

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Mention proxy flag in docs #3673

merged 4 commits into from
Nov 7, 2023

Conversation

Fashander
Copy link
Member

@Fashander Fashander commented Nov 1, 2023 •
edited
Loading

Description

Closes #3489.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@Fashander Fashander added documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets labels Nov 1, 2023
@Fashander Fashander added this to the Next milestone Nov 1, 2023
@Fashander Fashander requested a review from a team November 1, 2023 13:15
@Fashander Fashander self-assigned this Nov 1, 2023
@Fashander Fashander enabled auto-merge (squash) November 1, 2023 13:17
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2023 •
edited
Loading

Codecov Report

Merging #3673 (b35f481) into main (a60bc00) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3673      +/-   ##
==========================================
- Coverage   76.39%   76.36%   -0.03%     
==========================================
  Files         321      321              
  Lines       22950    22950              
==========================================
- Hits        17532    17526       -6     
- Misses       4388     4393       +5     
- Partials     1030     1031       +1

see 7 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.32% <ø> (-0.07%) ⬇️
hana-1 3.57% <ø> (ø)
integration 72.32% <ø> (-0.07%) ⬇️
mongodb-1 5.43% <ø> (ø)
postgresql-1 52.29% <ø> (-0.06%) ⬇️
postgresql-2 51.70% <ø> (ø)
postgresql-3 50.59% <ø> (ø)
sort-false 72.32% <ø> (-0.07%) ⬇️
sqlite-1 51.62% <ø> (-0.06%) ⬇️
sqlite-2 50.97% <ø> (ø)
sqlite-3 49.83% <ø> (ø)
unit 29.93% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are not related to newly added proxy flags, so added changes looks good 🤗. But just something I found while reading it.

website/docs/migration/premigration-testing.md Show resolved Hide resolved
website/docs/migration/premigration-testing.md Show resolved Hide resolved
b1ron
b1ron approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@b1ron b1ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked one question. Other than that, LGTM.

website/docs/migration/premigration-testing.md Show resolved Hide resolved
@AlekSi AlekSi added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Nov 6, 2023
@AlekSi AlekSi modified the milestones: v1.14.0, Next Nov 7, 2023
@Fashander Fashander merged commit 051e963 into FerretDB:main Nov 7, 2023
25 of 26 checks passed
@Fashander Fashander deleted the 3489 branch December 4, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1ron b1ron b1ron approved these changes

@ptrfarkas ptrfarkas ptrfarkas approved these changes

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner

Assignees

@Fashander Fashander

Labels
documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.

Mention proxy related flags in pre-migration testing
5 participants
@Fashander @chilagrow @ptrfarkas @b1ron @AlekSi