Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename main_postgeresql to main_postgresql #3668

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Rename main_postgeresql to main_postgresql #3668

merged 3 commits into from
Nov 2, 2023

Conversation

gen1us2k
Copy link
Contributor

@gen1us2k gen1us2k commented Oct 31, 2023 •
edited by noisersup
Loading

Description

There's a typo in the main_postgresql.go file and this PR fixes it. it would be great to keep names consistent.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gen1us2k gen1us2k changed the title renamed main_postgeresql to main_postgresql Renamed main_postgeresql to main_postgresql Oct 31, 2023
@gen1us2k gen1us2k changed the title Renamed main_postgeresql to main_postgresql code/chore: renamed main_postgeresql to main_postgresql Nov 2, 2023
@gen1us2k gen1us2k changed the title code/chore: renamed main_postgeresql to main_postgresql Renamed main_postgeresql to main_postgresql Nov 2, 2023
@gen1us2k gen1us2k marked this pull request as ready for review November 2, 2023 09:19
@gen1us2k gen1us2k requested a review from a team as a code owner November 2, 2023 09:19
@chilagrow chilagrow added the code/chore Code maintenance improvements label Nov 2, 2023
@chilagrow chilagrow added this to the Next milestone Nov 2, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023 •
edited
Loading

Codecov Report

Merging #3668 (dfc8caf) into main (c3f7da0) will decrease coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3668      +/-   ##
==========================================
- Coverage   76.80%   76.16%   -0.64%     
==========================================
  Files         321      321              
  Lines       22950    22950              
==========================================
- Hits        17626    17480     -146     
- Misses       4302     4433     +131     
- Partials     1022     1037      +15

see 18 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 72.17% <ø> (-0.69%) ⬇️
hana-1 ?
integration 72.17% <ø> (-0.72%) ⬇️
mongodb-1 5.43% <ø> (ø)
postgresql-1 52.29% <ø> (-0.41%) ⬇️
postgresql-2 51.70% <ø> (-0.27%) ⬇️
postgresql-3 50.59% <ø> (-0.30%) ⬇️
sort-false 72.17% <ø> (-0.21%) ⬇️
sort-true ?
sqlite-1 51.61% <ø> (-0.67%) ⬇️
sqlite-2 50.96% <ø> (-0.27%) ⬇️
sqlite-3 49.83% <ø> (-0.20%) ⬇️
unit 29.87% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix 🤗

@chilagrow chilagrow changed the title Renamed main_postgeresql to main_postgresql Rename main_postgeresql to main_postgresql Nov 2, 2023
@chilagrow chilagrow enabled auto-merge (squash) November 2, 2023 09:54
@chilagrow chilagrow requested review from a team and noisersup November 2, 2023 09:55
noisersup
noisersup approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I've needed some time to notice what's the problem 😅

@chilagrow chilagrow merged commit 76ea246 into FerretDB:main Nov 2, 2023
30 of 35 checks passed
@gen1us2k gen1us2k deleted the rename_main_pg branch November 2, 2023 12:51
@rumyantseva
Copy link
Contributor

Nice catch! 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@gen1us2k gen1us2k

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gen1us2k @CLAassistant @rumyantseva @chilagrow @noisersup