Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old pg handler #3661

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Remove old pg handler #3661

merged 3 commits into from
Oct 27, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 27, 2023

Description

Bye-bye.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #3661 (ec38ef1) into main (2715338) will increase coverage by 11.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3661       +/-   ##
===========================================
+ Coverage   62.11%   73.73%   +11.61%     
===========================================
  Files         430      369       -61     
  Lines       27906    23462     -4444     
===========================================
- Hits        17333    17299       -34     
+ Misses       9539     5128     -4411     
- Partials     1034     1035        +1     
Files Coverage Δ
internal/handlers/registry/postgresql.go 100.00% <ø> (+50.00%) ⬆️
internal/handlers/registry/registry.go 43.47% <ø> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
filter-true 69.91% <ø> (+11.16%) ⬆️
hana-1 ?
integration 69.91% <ø> (+11.16%) ⬆️
mongodb-1 5.31% <ø> (+0.85%) ⬆️
postgresql-1 51.20% <ø> (+8.24%) ⬆️
postgresql-2 48.03% <ø> (+7.74%) ⬆️
postgresql-3 50.71% <ø> (+8.13%) ⬆️
sort-false 69.91% <ø> (+11.16%) ⬆️
sqlite-1 50.50% <ø> (+8.13%) ⬆️
sqlite-2 47.40% <ø> (+7.67%) ⬆️
sqlite-3 49.94% <ø> (+8.05%) ⬆️
unit 27.33% <ø> (+4.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 27, 2023
@AlekSi AlekSi added this to the Next milestone Oct 27, 2023
@AlekSi AlekSi marked this pull request as ready for review October 27, 2023 18:07
@AlekSi AlekSi requested a review from a team as a code owner October 27, 2023 18:07
@AlekSi AlekSi merged commit 767c6e7 into FerretDB:main Oct 27, 2023
27 of 28 checks passed
@AlekSi AlekSi deleted the remove-pgdb branch October 27, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant