Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable interactivity on blogpost #3659

Merged
merged 30 commits into from
Nov 15, 2023
Merged

Enable interactivity on blogpost #3659

merged 30 commits into from
Nov 15, 2023

Conversation

Fashander
Copy link
Member

@Fashander Fashander commented Oct 27, 2023

Description

Closes FerretDB/engineering#87.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@Fashander Fashander added do not merge PRs that should not be merged blog/marketing Marketing (and releases) blog posts labels Oct 27, 2023
@Fashander Fashander self-assigned this Oct 27, 2023
@Fashander Fashander enabled auto-merge (squash) October 27, 2023 11:24
@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2023

Marketing blog posts should be reviewed by @ptrfarkas and @AlekSi.

@Fashander
Copy link
Member Author

Currently it still shows that the domain is not allowed. Screenshot 2023-10-27 at 12 25 15

@Fashander Fashander added the trust PRs that can access Actions secrets label Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #3659 (98b7d56) into main (b7fa5c3) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3659      +/-   ##
==========================================
+ Coverage   76.33%   76.36%   +0.03%     
==========================================
  Files         323      323              
  Lines       23034    23034              
==========================================
+ Hits        17582    17590       +8     
+ Misses       4412     4406       -6     
+ Partials     1040     1038       -2     

see 3 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.40% <ø> (+0.03%) ⬆️
hana-1 3.61% <ø> (ø)
integration 72.40% <ø> (+0.03%) ⬆️
mongodb-1 5.46% <ø> (ø)
postgresql-1 52.47% <ø> (+<0.01%) ⬆️
postgresql-2 51.65% <ø> (ø)
postgresql-3 50.71% <ø> (ø)
sort-false 72.40% <ø> (+0.03%) ⬆️
sqlite-1 51.67% <ø> (-0.06%) ⬇️
sqlite-2 50.84% <ø> (-0.01%) ⬇️
sqlite-3 49.88% <ø> (ø)
unit 30.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Fashander Fashander changed the title Tested interactive blog Test interactive blog Oct 27, 2023
@Fashander Fashander removed the do not merge PRs that should not be merged label Oct 27, 2023
@Fashander Fashander added documentation Something user-visible is badly or not documented do not merge PRs that should not be merged labels Oct 27, 2023
auto-merge was automatically disabled November 9, 2023 09:39

Pull request was converted to draft

Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for review, I guess

@Fashander Fashander added not ready Issues that are not ready to be worked on; PRs that should skip CI do not merge PRs that should not be merged labels Nov 9, 2023
@Fashander Fashander removed not ready Issues that are not ready to be worked on; PRs that should skip CI do not merge PRs that should not be merged labels Nov 14, 2023
@Fashander Fashander changed the title Test interactive blog Enable interactivity on blogpost Nov 15, 2023
@Fashander
Copy link
Member Author

@AlekSi PTAL

@AlekSi AlekSi added this to the Next milestone Nov 15, 2023
@Fashander Fashander merged commit 6c5c709 into FerretDB:main Nov 15, 2023
26 of 27 checks passed
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Nov 16, 2023
@Fashander Fashander deleted the codeapi branch December 4, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog/marketing Marketing (and releases) blog posts trust PRs that can access Actions secrets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants