Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run backend tests for SAP HANA #3657

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Run backend tests for SAP HANA #3657

merged 2 commits into from
Oct 26, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 26, 2023 •
edited
Loading

Description

To make it easier to work on it.

Plus bump deps.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 26, 2023
@AlekSi AlekSi added this to the Next milestone Oct 26, 2023
@AlekSi AlekSi self-assigned this Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #3657 (2f855a2) into main (ebe7cd1) will decrease coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3657      +/-   ##
==========================================
- Coverage   62.59%   61.98%   -0.61%     
==========================================
  Files         430      430              
  Lines       27906    27906              
==========================================
- Hits        17467    17298     -169     
- Misses       9417     9572     +155     
- Partials     1022     1036      +14

see 18 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 58.62% <ø> (-0.60%) ⬇️
hana-1 ?
integration 58.62% <ø> (-0.64%) ⬇️
mongodb-1 4.46% <ø> (ø)
postgresql-1 42.96% <ø> (-0.25%) ⬇️
postgresql-2 40.29% <ø> (-0.33%) ⬇️
postgresql-3 42.49% <ø> (-0.45%) ⬇️
sort-false 58.62% <ø> (-0.20%) ⬇️
sort-true ?
sqlite-1 42.37% <ø> (-0.15%) ⬇️
sqlite-2 39.73% <ø> (-0.23%) ⬇️
sqlite-3 41.98% <ø> (-0.46%) ⬇️
unit 22.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review October 26, 2023 15:45
@AlekSi AlekSi enabled auto-merge (squash) October 26, 2023 15:45
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup October 26, 2023 15:46
noisersup
noisersup approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rumyantseva
rumyantseva approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit d6d3a43 into FerretDB:main Oct 26, 2023
27 of 28 checks passed
@AlekSi AlekSi deleted the hana-tests branch October 26, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @noisersup