Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golangci-lint #3651

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Update golangci-lint #3651

merged 4 commits into from
Oct 26, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 25, 2023

Description

Also, replace https://github.com/BurntSushi/go-sumtype with https://github.com/alecthomas/go-check-sumtype.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • [ x I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Oct 25, 2023
@AlekSi AlekSi added the deps PRs that update dependencies label Oct 25, 2023
@AlekSi AlekSi added this to the Next milestone Oct 25, 2023
@AlekSi AlekSi marked this pull request as ready for review October 25, 2023 13:33
@AlekSi AlekSi requested a review from a team as a code owner October 25, 2023 13:33
@AlekSi AlekSi enabled auto-merge (squash) October 25, 2023 13:33
@AlekSi AlekSi requested review from a team and noisersup October 25, 2023 13:33
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #3651 (be6a29d) into main (d6d3a43) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3651      +/-   ##
==========================================
- Coverage   62.07%   62.00%   -0.07%     
==========================================
  Files         430      430              
  Lines       27906    27906              
==========================================
- Hits        17322    17304      -18     
- Misses       9547     9568      +21     
+ Partials     1037     1034       -3
Files Coverage Δ
...ommon/aggregations/stages/projection/projection.go 87.02% <ø> (ø)
internal/types/types.go 94.20% <ø> (ø)
internal/wire/msg_body.go 47.05% <ø> (ø)
internal/bson/bson.go 43.33% <0.00%> (ø)
internal/handlers/sjson/sjson.go 85.65% <0.00%> (ø)
internal/types/fjson/fjson.go 89.39% <0.00%> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
filter-true 58.64% <0.00%> (-0.08%) ⬇️
hana-1 ?
integration 58.64% <0.00%> (-0.08%) ⬇️
mongodb-1 4.46% <0.00%> (ø)
postgresql-1 42.96% <0.00%> (ø)
postgresql-2 40.29% <0.00%> (ø)
postgresql-3 42.49% <0.00%> (-0.10%) ⬇️
sort-false 58.64% <0.00%> (-0.08%) ⬇️
sqlite-1 42.37% <0.00%> (ø)
sqlite-2 39.76% <0.00%> (+0.03%) ⬆️
sqlite-3 41.98% <0.00%> (+0.03%) ⬆️
unit 22.79% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi merged commit b734008 into FerretDB:main Oct 26, 2023
25 of 26 checks passed
@AlekSi AlekSi deleted the lint branch October 26, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
deps PRs that update dependencies
Projects
Current Engineering
Archived in project
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @chilagrow @noisersup