Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for capped collection in aggregate $collStats #3643

Merged
merged 7 commits into from
Oct 28, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Oct 25, 2023

Description

Closes #2447.

Keep #2447 open.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Oct 25, 2023
@chilagrow chilagrow added this to the Next milestone Oct 25, 2023
@chilagrow chilagrow self-assigned this Oct 25, 2023
@chilagrow chilagrow marked this pull request as ready for review October 25, 2023 03:30
@chilagrow chilagrow requested a review from a team as a code owner October 25, 2023 03:30
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team and noisersup October 25, 2023 03:30
@chilagrow chilagrow enabled auto-merge (squash) October 25, 2023 03:31
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #3643 (f4453d9) into main (a3f9ed8) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3643      +/-   ##
==========================================
- Coverage   73.89%   73.73%   -0.17%     
==========================================
  Files         369      369              
  Lines       23462    23462              
==========================================
- Hits        17338    17299      -39     
- Misses       5092     5128      +36     
- Partials     1032     1035       +3     

see 9 files with indirect coverage changes

Flag Coverage Δ
filter-true 69.91% <ø> (-0.16%) ⬇️
hana-1 ?
integration 69.91% <ø> (-0.16%) ⬇️
mongodb-1 5.31% <ø> (ø)
postgresql-1 51.20% <ø> (ø)
postgresql-2 48.04% <ø> (+<0.01%) ⬆️
postgresql-3 50.76% <ø> (+0.12%) ⬆️
sort-false 69.91% <ø> (-0.16%) ⬇️
sqlite-1 50.50% <ø> (ø)
sqlite-2 47.36% <ø> (-0.05%) ⬇️
sqlite-3 50.05% <ø> (+0.05%) ⬆️
unit 27.33% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow requested a review from AlekSi October 26, 2023 05:46
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow merged commit e180e61 into FerretDB:main Oct 28, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add more data to the output of collStats and dbStats commands
3 participants