Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support showRecordId in find #3637

Merged
merged 19 commits into from
Nov 8, 2023
Merged

Support showRecordId in find #3637

merged 19 commits into from
Nov 8, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Oct 24, 2023 •
edited
Loading

Description

Closes #3467.

Also renames enable sort pushdown to unsafe sort pushdown and limit pushdown to unsafe limit pushdown.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/feature Some user-visible feature is not implemented yet label Oct 24, 2023
@chilagrow chilagrow added this to the Next milestone Oct 24, 2023
@chilagrow chilagrow self-assigned this Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

Merging #3637 (d835b19) into main (b31b8e2) will decrease coverage by 0.65%.
The diff coverage is 88.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3637      +/-   ##
==========================================
- Coverage   76.88%   76.23%   -0.65%     
==========================================
  Files         321      321              
  Lines       22950    22958       +8     
==========================================
- Hits        17644    17502     -142     
- Misses       4290     4423     +133     
- Partials     1016     1033      +17
Files Coverage Δ
integration/setup/listener.go 80.44% <100.00%> (-2.23%) ⬇️
integration/setup/setup.go 79.77% <ø> (ø)
integration/setup/test_helpers.go 80.00% <100.00%> (ø)
internal/backends/collection.go 100.00% <ø> (ø)
internal/backends/postgresql/collection.go 71.35% <100.00%> (ø)
internal/backends/sqlite/collection.go 80.15% <100.00%> (-0.80%) ⬇️
internal/clientconn/cursor/cursor.go 100.00% <100.00%> (ø)
internal/clientconn/cursor/registry.go 91.66% <100.00%> (ø)
internal/handlers/common/find.go 100.00% <ø> (ø)
internal/handlers/common/getmore.go 92.76% <100.00%> (+0.09%) ⬆️
... and 10 more

... and 9 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 72.25% <88.33%> (-0.60%) ⬇️
hana-1 ?
integration 72.25% <88.33%> (-0.67%) ⬇️
mongodb-1 5.43% <0.00%> (-0.01%) ⬇️
postgresql-1 52.55% <65.00%> (-0.20%) ⬇️
postgresql-2 50.42% <60.00%> (-1.56%) ⬇️
postgresql-3 51.68% <60.00%> (+0.84%) ⬆️
sort-false 72.25% <88.33%> (-0.20%) ⬇️
sort-true ?
sqlite-1 51.86% <73.33%> (-0.43%) ⬇️
sqlite-2 49.74% <68.33%> (-1.49%) ⬇️
sqlite-3 50.84% <68.33%> (+0.81%) ⬆️
unit 29.86% <19.60%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review October 25, 2023 04:18
@chilagrow chilagrow requested review from AlekSi, ptrfarkas and a team as code owners October 25, 2023 04:18
@chilagrow chilagrow requested a review from rumyantseva October 25, 2023 04:18
@chilagrow chilagrow enabled auto-merge (squash) October 25, 2023 04:19
@chilagrow chilagrow requested review from a team and noisersup October 25, 2023 04:19
noisersup
noisersup previously approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow marked this pull request as draft October 27, 2023 08:39
auto-merge was automatically disabled October 27, 2023 08:39

Pull request was converted to draft

@chilagrow chilagrow marked this pull request as ready for review October 30, 2023 02:38
@chilagrow chilagrow enabled auto-merge (squash) October 30, 2023 02:38
@chilagrow chilagrow requested a review from noisersup October 30, 2023 02:39
noisersup
noisersup previously approved these changes Oct 31, 2023
View reviewed changes
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2023

@chilagrow this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Nov 1, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Nov 2, 2023
@chilagrow chilagrow requested a review from noisersup November 2, 2023 03:02
@chilagrow chilagrow assigned noisersup and unassigned chilagrow Nov 2, 2023
noisersup
noisersup previously approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Waiting for other reviews :)

rumyantseva
rumyantseva previously approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlekSi AlekSi modified the milestones: v1.14.0, Next Nov 7, 2023
@AlekSi AlekSi dismissed stale reviews from rumyantseva and noisersup via a2452da November 7, 2023 12:12
@AlekSi AlekSi disabled auto-merge November 8, 2023 06:27
@AlekSi AlekSi merged commit 3232afd into FerretDB:main Nov 8, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup left review comments

@rumyantseva rumyantseva rumyantseva left review comments

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

Assignees

@noisersup noisersup

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.

Support finds showRecordId
4 participants
@chilagrow @rumyantseva @noisersup @AlekSi