Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue tracking to checkcomments analyzer #3632

Merged
merged 14 commits into from
Nov 15, 2023
Merged

Conversation

raeidish
Copy link
Contributor

Description

Implemented github issue tracking for checkcomments analyzer, uses lockedfile to limit number of requests.

Closes #2733

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #3632 (81b4e0f) into main (07a145f) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3632      +/-   ##
==========================================
- Coverage   76.21%   76.19%   -0.03%     
==========================================
  Files         323      323              
  Lines       23043    23035       -8     
==========================================
- Hits        17563    17552      -11     
- Misses       4436     4440       +4     
+ Partials     1044     1043       -1     
Files Coverage Δ
integration/setup/test_helpers.go 100.00% <ø> (+20.00%) ⬆️

... and 7 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.22% <ø> (-0.03%) ⬇️
hana-1 ?
integration 72.22% <ø> (-0.03%) ⬇️
mongodb-1 5.46% <ø> (+<0.01%) ⬆️
postgresql-1 52.49% <ø> (+0.06%) ⬆️
postgresql-2 51.63% <ø> (+0.02%) ⬆️
postgresql-3 50.68% <ø> (+0.01%) ⬆️
sort-false 72.22% <ø> (-0.03%) ⬇️
sqlite-1 ?
sqlite-2 50.82% <ø> (+0.01%) ⬆️
sqlite-3 49.86% <ø> (+0.01%) ⬆️
unit 30.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@raeidish raeidish marked this pull request as ready for review October 24, 2023 16:04
@raeidish raeidish requested a review from AlekSi as a code owner October 24, 2023 16:04
@AlekSi
Copy link
Member

AlekSi commented Oct 30, 2023

Oh, sorry, we missed that. Will review shortly

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 30, 2023
@AlekSi AlekSi added this to the Next milestone Oct 30, 2023
@AlekSi AlekSi requested a review from a team as a code owner October 31, 2023 16:33
@AlekSi AlekSi requested a review from rumyantseva October 31, 2023 16:33
@AlekSi AlekSi modified the milestones: v1.14.0, Next Nov 7, 2023
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! I left a couple of questions.

tools/Taskfile.yml Show resolved Hide resolved
tools/checkcomments/checkcomments.go Show resolved Hide resolved
tools/checkcomments/checkcomments.go Show resolved Hide resolved
@rumyantseva rumyantseva self-assigned this Nov 13, 2023
@raeidish raeidish requested a review from rumyantseva November 14, 2023 15:45
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi enabled auto-merge (squash) November 15, 2023 17:40
@AlekSi
Copy link
Member

AlekSi commented Nov 15, 2023

Thank you!

@AlekSi AlekSi merged commit e17d6a4 into FerretDB:main Nov 15, 2023
26 checks passed
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Nov 16, 2023
Closes FerretDB#2733.

Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
Co-authored-by: Elena Grahovac <elena.grahovac@ferretdb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Make linter for checking that linked issues are open
3 participants