Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create OpLog database/collection on a fly #3625

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 20, 2023

Description

It should be created manually.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #3625 (4976d37) into main (d1aad78) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3625      +/-   ##
==========================================
- Coverage   61.69%   61.48%   -0.22%     
==========================================
  Files         426      427       +1     
  Lines       27654    27698      +44     
==========================================
- Hits        17062    17030      -32     
- Misses       9578     9651      +73     
- Partials     1014     1017       +3     
Files Coverage Δ
internal/backends/decorators/oplog/backend.go 0.00% <0.00%> (ø)
internal/backends/decorators/oplog/database.go 0.00% <0.00%> (ø)
internal/backends/decorators/oplog/oplog.go 0.00% <0.00%> (ø)
internal/backends/decorators/oplog/collection.go 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

Flag Coverage Δ
filter-true 58.09% <0.00%> (-0.20%) ⬇️
hana-1 ?
integration 58.09% <0.00%> (-0.20%) ⬇️
mongodb-1 4.47% <0.00%> (-0.01%) ⬇️
postgresql-1 42.28% <0.00%> (-0.08%) ⬇️
postgresql-2 39.80% <0.00%> (-0.07%) ⬇️
postgresql-3 41.86% <0.00%> (-0.16%) ⬇️
sort-false 58.09% <0.00%> (-0.20%) ⬇️
sqlite-1 42.12% <0.00%> (-0.07%) ⬇️
sqlite-2 39.27% <0.00%> (-0.03%) ⬇️
sqlite-3 41.53% <0.00%> (-0.06%) ⬇️
unit 22.68% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review October 20, 2023 14:29
@AlekSi AlekSi enabled auto-merge (squash) October 20, 2023 14:29
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup October 20, 2023 14:30
@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 20, 2023
@AlekSi AlekSi added this to the Next milestone Oct 20, 2023
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi disabled auto-merge October 20, 2023 14:37
@AlekSi AlekSi merged commit 55d3333 into FerretDB:main Oct 20, 2023
28 of 31 checks passed
@AlekSi AlekSi deleted the oplog-collection branch October 20, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants