Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate PostgreSQL databases in tests #3622

Merged
merged 42 commits into from
Nov 10, 2023
Merged

Use separate PostgreSQL databases in tests #3622

merged 42 commits into from
Nov 10, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 20, 2023 •
edited
Loading

Description

Plus various accumulated refactorings and cleanups.

Closes #3409.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

Merging #3622 (ed7199b) into main (c303194) will decrease coverage by 0.22%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3622      +/-   ##
==========================================
- Coverage   76.42%   76.20%   -0.22%     
==========================================
  Files         321      323       +2     
  Lines       22969    23004      +35     
==========================================
- Hits        17553    17530      -23     
- Misses       4387     4435      +48     
- Partials     1029     1039      +10
Files Coverage Δ
integration/setup/listener.go 73.80% <100.00%> (-8.86%) ⬇️
integration/setup/setup.go 79.77% <ø> (ø)
internal/backends/postgresql/backend.go 64.10% <ø> (ø)
internal/backends/postgresql/metadata/registry.go 70.67% <ø> (-0.62%) ⬇️
internal/backends/postgresql/query.go 93.22% <100.00%> (+0.45%) ⬆️
internal/backends/sqlite/backend.go 77.96% <ø> (ø)
internal/handlers/sqlite/msg_aggregate.go 84.01% <ø> (ø)
internal/handlers/sqlite/msg_collstats.go 73.68% <100.00%> (+0.23%) ⬆️
internal/util/testutil/sqlite.go 100.00% <100.00%> (ø)
internal/util/resource/resource.go 66.10% <50.00%> (-1.76%) ⬇️
... and 1 more

... and 8 files with indirect coverage changes

Flag Coverage Δ
filter-true 72.23% <88.42%> (-0.21%) ⬇️
hana-1 ?
integration 72.23% <88.42%> (-0.21%) ⬇️
mongodb-1 5.47% <2.10%> (-0.01%) ⬇️
postgresql-1 52.55% <53.68%> (-0.02%) ⬇️
postgresql-2 50.45% <61.05%> (-0.01%) ⬇️
postgresql-3 51.68% <55.78%> (-0.02%) ⬇️
sort-false 72.23% <88.42%> (-0.21%) ⬇️
sqlite-1 51.84% <25.26%> (+0.06%) ⬆️
sqlite-2 49.73% <29.47%> (-0.09%) ⬇️
sqlite-3 50.77% <25.26%> (-0.10%) ⬇️
unit 30.12% <84.94%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Oct 20, 2023
@AlekSi AlekSi added this to the Next milestone Oct 20, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 20, 2023
@AlekSi AlekSi modified the milestones: v1.13.0, Next Oct 23, 2023
@AlekSi AlekSi changed the title Postgresql databases Use separate PostgreSQL databases in tests Nov 9, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Nov 9, 2023
@AlekSi AlekSi marked this pull request as ready for review November 9, 2023 17:40
@AlekSi AlekSi requested a review from a team as a code owner November 9, 2023 17:40
@AlekSi AlekSi requested a review from rumyantseva November 9, 2023 17:40
@AlekSi AlekSi enabled auto-merge (squash) November 9, 2023 17:40
@AlekSi AlekSi requested review from a team and noisersup November 9, 2023 17:40
rumyantseva
rumyantseva approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi disabled auto-merge November 10, 2023 15:01
@AlekSi AlekSi merged commit 1f18df0 into FerretDB:main Nov 10, 2023
27 checks passed
@AlekSi AlekSi deleted the postgresql-databases branch November 10, 2023 15:01
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Nov 16, 2023
@AlekSi @yonarw
Use separate PostgreSQL databases in tests (FerretDB#3622)
de4e904 
Closes FerretDB#3409.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.

Some backend tests are fluky
2 participants
@AlekSi @rumyantseva