Optimize insert performance by batching
#3621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3621 +/- ##
==========================================
- Coverage 74.17% 74.07% -0.10%
==========================================
Files 370 372 +2
Lines 23564 23626 +62
==========================================
+ Hits 17478 17502 +24
- Misses 5059 5093 +34
- Partials 1027 1031 +4
... and 12 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
AlekSi
reviewed
Oct 20, 2023
|
@princejha95 this pull request has merge conflicts. |
chilagrow
changed the title
chilagrow
previously approved these changes
Oct 27, 2023
chilagrow
previously approved these changes
Oct 30, 2023
AlekSi
changed the title
insert performance by batching
AlekSi
reviewed
Oct 30, 2023
|
|
||
| if params.Ordered { | ||
| break | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Let's simplify that with
if err = doc.ValidateData(); err == nil {
docs = append(docs, doc)
docsIndexes = append(docsIndexes, int32(i))
continue
}
Comment on lines
116
to
120
| var j int | ||
| for i := 0; i < len(params.Docs); i += batchSize { | ||
| if j += batchSize; j > len(params.Docs) { | ||
| j = len(params.Docs) | ||
| } |
There was a problem hiding this comment.
I think that could be simplifying by using a slice instead of a second index j:
docs := params.Docs
// ...
i := min(batchSize, len(docs))
batch, docs := docs[:i], docs[i:]There was a problem hiding this comment.
Thanks it's easier to read too
AlekSi
reviewed
Oct 30, 2023
| metadata.DefaultColumn, | ||
| ) | ||
| args = append(args, doc.RecordID()) | ||
| q, args, err := prepareInsertStatement(meta.TableName, meta.Settings.CappedSize > 0, params.Docs[i:j]) |
There was a problem hiding this comment.
Let's add a method for meta.Settings.CappedSize > 0
There was a problem hiding this comment.
It was already added by another PR, using it now 👍
Comment on lines
95
to
98
| for { | ||
| i, d, err := docsIter.Next() | ||
| if errors.Is(err, iterator.ErrIteratorDone) { | ||
| if done { | ||
| break | ||
| } |
…tDB into clean_optimise_inserts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3271.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.