Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some tests for SQLite backend #3617

Merged
merged 14 commits into from
Oct 20, 2023
Merged

Fix some tests for SQLite backend #3617

merged 14 commits into from
Oct 20, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 19, 2023 •
edited
Loading

Description

This PR prevents loading of database files from disk when in-memory URL is used.
Plus a few smaller fixes.

Closes #3409.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Oct 19, 2023
@AlekSi AlekSi added this to the Next milestone Oct 19, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Merging #3617 (67f6ef8) into main (10e186c) will decrease coverage by 0.56%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3617      +/-   ##
==========================================
- Coverage   62.16%   61.60%   -0.56%     
==========================================
  Files         426      426              
  Lines       27649    27654       +5     
==========================================
- Hits        17188    17037     -151     
- Misses       9461     9604     +143     
- Partials     1000     1013      +13
Files Coverage Δ
internal/backends/sqlite/metadata/pool/opendb.go 60.60% <100.00%> (+2.54%) ⬆️
internal/backends/sqlite/metadata/pool/uri.go 85.71% <100.00%> (ø)
internal/handlers/pg/msg_update.go 0.00% <0.00%> (ø)
internal/backends/sqlite/collection.go 79.55% <0.00%> (-0.39%) ⬇️
internal/backends/postgresql/collection.go 64.72% <0.00%> (-4.46%) ⬇️
internal/backends/sqlite/metadata/pool/pool.go 62.75% <45.45%> (-0.56%) ⬇️

... and 14 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 58.20% <31.81%> (-0.54%) ⬇️
hana-1 ?
integration 58.20% <31.81%> (-0.55%) ⬇️
mongodb-1 4.48% <0.00%> (-0.01%) ⬇️
postgresql-1 42.36% <0.00%> (-0.27%) ⬇️
postgresql-2 39.87% <0.00%> (-0.18%) ⬇️
postgresql-3 42.02% <0.00%> (-0.14%) ⬇️
sort-false 58.20% <31.81%> (-0.13%) ⬇️
sort-true ?
sqlite-1 42.19% <31.81%> (-0.10%) ⬇️
sqlite-2 39.35% <31.81%> (-0.05%) ⬇️
sqlite-3 41.58% <31.81%> (-0.32%) ⬇️
unit 22.73% <45.45%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi changed the title Fix tests for SQLite backend Fix some tests for SQLite backend Oct 19, 2023
@AlekSi AlekSi marked this pull request as ready for review October 20, 2023 04:52
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners October 20, 2023 04:52
@AlekSi AlekSi enabled auto-merge (squash) October 20, 2023 04:52
@AlekSi AlekSi requested review from a team and noisersup October 20, 2023 04:53
@AlekSi AlekSi mentioned this pull request Oct 20, 2023
Merged
9 tasks
@AlekSi AlekSi added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Oct 20, 2023
@rumyantseva rumyantseva added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Oct 20, 2023
rumyantseva
rumyantseva approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi disabled auto-merge October 20, 2023 13:49
@AlekSi AlekSi merged commit d1aad78 into FerretDB:main Oct 20, 2023
70 of 71 checks passed
@AlekSi AlekSi deleted the memory-database branch October 20, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Some backend tests are fluky
4 participants
@AlekSi @rumyantseva @chilagrow @noisersup