Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support create for capped collections #3614

Merged
merged 35 commits into from
Oct 24, 2023
Merged

Support create for capped collections #3614

merged 35 commits into from
Oct 24, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Oct 19, 2023 •
edited
Loading

Description

Closes #3458.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Oct 19, 2023
@rumyantseva rumyantseva self-assigned this Oct 19, 2023
@rumyantseva rumyantseva added code/feature Some user-visible feature is not implemented yet and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Oct 19, 2023
@rumyantseva rumyantseva added this to the Next milestone Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Merging #3614 (8d836d7) into main (1026d86) will increase coverage by 0.33%.
The diff coverage is 92.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3614      +/-   ##
==========================================
+ Coverage   61.63%   61.97%   +0.33%     
==========================================
  Files         427      427              
  Lines       27730    27801      +71     
==========================================
+ Hits        17092    17230     +138     
+ Misses       9618     9546      -72     
- Partials     1020     1025       +5
Files Coverage Δ
integration/setup/listener.go 80.61% <100.00%> (-2.21%) ⬇️
integration/setup/setup.go 79.77% <ø> (ø)
internal/backends/database.go 97.26% <ø> (ø)
internal/backends/postgresql/database.go 73.45% <100.00%> (+1.75%) ⬆️
internal/backends/postgresql/metadata/metadata.go 62.66% <100.00%> (+5.74%) ⬆️
internal/backends/postgresql/metadata/registry.go 71.20% <100.00%> (+0.26%) ⬆️
internal/backends/sqlite/database.go 78.78% <100.00%> (+4.87%) ⬆️
internal/backends/sqlite/metadata/metadata.go 100.00% <ø> (ø)
internal/backends/sqlite/metadata/registry.go 71.15% <100.00%> (+1.83%) ⬆️
internal/backends/sqlite/metadata/settings.go 67.56% <100.00%> (+1.85%) ⬆️
... and 5 more

... and 11 files with indirect coverage changes

Flag Coverage Δ
filter-true 58.57% <87.06%> (+0.31%) ⬆️
hana-1 ?
integration 58.57% <87.06%> (+0.31%) ⬆️
mongodb-1 4.44% <0.00%> (-0.02%) ⬇️
postgresql-1 42.69% <47.41%> (-0.14%) ⬇️
postgresql-2 43.20% <45.68%> (+3.31%) ⬆️
postgresql-3 40.34% <59.48%> (-1.85%) ⬇️
sort-false 58.57% <87.06%> (+0.31%) ⬆️
sqlite-1 41.96% <41.37%> (-0.28%) ⬇️
sqlite-2 42.60% <39.65%> (+3.23%) ⬆️
sqlite-3 39.78% <53.44%> (-1.81%) ⬇️
unit 22.76% <56.52%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva marked this pull request as ready for review October 19, 2023 20:06
@rumyantseva rumyantseva requested review from AlekSi, ptrfarkas and a team as code owners October 19, 2023 20:06
@rumyantseva rumyantseva requested review from chilagrow, a team and noisersup October 19, 2023 20:06
chilagrow
chilagrow reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good 👍

integration/create_test.go Show resolved Hide resolved
internal/backends/sqlite/metadata/registry.go Outdated Show resolved Hide resolved
Elena Grahovac and others added 2 commits October 20, 2023 09:33
@chilagrow
Update internal/backends/sqlite/metadata/registry.go
c825d42 
Co-authored-by: Chi Fujii <chi.fujii@ferretdb.io>
@rumyantseva
wip
8d24039
AlekSi
AlekSi reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but let's use a feature flag

integration/commands_administration_compat_test.go Outdated Show resolved Hide resolved
internal/backends/postgresql/metadata/metadata.go Outdated Show resolved Hide resolved
internal/backends/sqlite/metadata/settings.go Outdated Show resolved Hide resolved
internal/handlers/sqlite/msg_create.go Outdated Show resolved Hide resolved
internal/handlers/sqlite/msg_create.go Outdated Show resolved Hide resolved
internal/handlers/sqlite/msg_create.go Outdated Show resolved Hide resolved
@chilagrow chilagrow mentioned this pull request Oct 20, 2023
Merged
9 tasks
chilagrow
chilagrow reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one tiny comment 🤗

internal/handlers/sqlite/msg_create.go Outdated Show resolved Hide resolved
@rumyantseva rumyantseva requested a review from chilagrow October 23, 2023 06:57
chilagrow
chilagrow previously approved these changes Oct 23, 2023
View reviewed changes
@AlekSi AlekSi modified the milestones: v1.13.0, Next Oct 23, 2023
AlekSi
AlekSi reviewed Oct 23, 2023
View reviewed changes
internal/backends/postgresql/database.go Outdated Show resolved Hide resolved
internal/backends/postgresql/metadata/metadata.go Outdated Show resolved Hide resolved
internal/backends/postgresql/metadata/registry.go Outdated Show resolved Hide resolved
internal/backends/sqlite/metadata/settings.go Outdated Show resolved Hide resolved
integration/commands_administration_compat_test.go Outdated Show resolved Hide resolved
integration/create_test.go Outdated Show resolved Hide resolved
integration/create_test.go Outdated Show resolved Hide resolved
integration/create_test.go Outdated Show resolved Hide resolved
integration/create_test.go Outdated Show resolved Hide resolved
internal/backends/postgresql/metadata/metadata.go Show resolved Hide resolved
noisersup
noisersup previously approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After addressing previous comments, it seems to me ready to be merged :)

@rumyantseva rumyantseva dismissed stale reviews from noisersup and chilagrow via d269272 October 23, 2023 22:36
rumyantseva and others added 6 commits October 24, 2023 00:38
@rumyantseva
wip
ec8755e
@AlekSi
Update internal/backends/postgresql/metadata/metadata.go
48dc636 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@AlekSi
Update internal/backends/sqlite/metadata/settings.go
f75012a 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@AlekSi
Update integration/commands_administration_compat_test.go
562d2cd 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@rumyantseva
wip
aef0773
@chilagrow
refactor
afc5470
@AlekSi AlekSi disabled auto-merge October 24, 2023 08:33
@AlekSi AlekSi enabled auto-merge (squash) October 24, 2023 08:33
@AlekSi AlekSi merged commit a8880e8 into FerretDB:main Oct 24, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@noisersup noisersup Awaiting requested review from noisersup

Assignees

@rumyantseva rumyantseva

@chilagrow chilagrow

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.

Support create for capped collections
4 participants
@rumyantseva @AlekSi @chilagrow @noisersup