Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep envtool's version always up-to-date #3609

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Keep envtool's version always up-to-date #3609

merged 4 commits into from
Oct 19, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 19, 2023

Description

Fixes things like tests panicking after commit, etc.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 19, 2023
@AlekSi AlekSi added this to the Next milestone Oct 19, 2023
@AlekSi AlekSi self-assigned this Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Merging #3609 (3ba1efe) into main (24498a4) will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3609      +/-   ##
==========================================
- Coverage   61.70%   61.39%   -0.31%     
==========================================
  Files         426      426              
  Lines       27649    27649              
==========================================
- Hits        17060    16975      -85     
- Misses       9575     9654      +79     
- Partials     1014     1020       +6

see 10 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.92% <ø> (-0.38%) ⬇️
hana-1 ?
integration 57.92% <ø> (-0.38%) ⬇️
mongodb-1 4.48% <ø> (ø)
postgresql-1 42.36% <ø> (-0.02%) ⬇️
postgresql-2 39.87% <ø> (ø)
postgresql-3 41.98% <ø> (+<0.01%) ⬆️
sort-false 57.92% <ø> (-0.38%) ⬇️
sqlite-1 42.19% <ø> (ø)
sqlite-2 39.34% <ø> (ø)
sqlite-3 ?
unit 22.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review October 19, 2023 05:26
@AlekSi AlekSi enabled auto-merge (squash) October 19, 2023 05:26
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup October 19, 2023 05:26
@AlekSi AlekSi merged commit 10e186c into FerretDB:main Oct 19, 2023
26 checks passed
@AlekSi AlekSi deleted the envtool-rebuild branch October 19, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @chilagrow @noisersup