Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip filter pushdown integration tests #3605

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Unskip filter pushdown integration tests #3605

merged 3 commits into from
Oct 18, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Oct 18, 2023 •
edited
Loading

Description

Closes #3526.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #3605 (2e739ce) into main (6650ab5) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3605      +/-   ##
==========================================
+ Coverage   61.45%   61.54%   +0.09%     
==========================================
  Files         426      426              
  Lines       27528    27528              
==========================================
+ Hits        16917    16942      +25     
+ Misses       9594     9572      -22     
+ Partials     1017     1014       -3

see 16 files with indirect coverage changes

Flag Coverage Δ
filter-true 58.09% <ø> (+0.31%) ⬆️
hana-1 ?
integration 58.09% <ø> (+0.31%) ⬆️
mongodb-1 4.49% <ø> (ø)
postgresql-1 39.51% <ø> (?)
postgresql-2 41.97% <ø> (+0.33%) ⬆️
postgresql-3 42.76% <ø> (+0.87%) ⬆️
sort-false 58.09% <ø> (+0.31%) ⬆️
sqlite-1 39.39% <ø> (-0.03%) ⬇️
sqlite-3 42.27% <ø> (ø)
unit 22.49% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup changed the title Fix filter pushdown Unskip filter pushdown integration tests Oct 18, 2023
@noisersup noisersup added code/feature Some user-visible feature is not implemented yet code/chore Code maintenance improvements and removed code/feature Some user-visible feature is not implemented yet labels Oct 18, 2023
@noisersup noisersup added this to the Next milestone Oct 18, 2023
@noisersup noisersup marked this pull request as ready for review October 18, 2023 14:06
@noisersup noisersup requested a review from a team as a code owner October 18, 2023 14:06
@noisersup noisersup enabled auto-merge (squash) October 18, 2023 14:06
rumyantseva
rumyantseva approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rumyantseva rumyantseva requested review from a team and chilagrow October 18, 2023 14:17
@noisersup noisersup merged commit f433e25 into FerretDB:main Oct 18, 2023
26 checks passed
@noisersup noisersup deleted the fix-filter-pushdown-3526 branch October 18, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Fix filter pushdown
3 participants
@noisersup @AlekSi @rumyantseva