Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for MongoDB with enabled replica set #3604

Merged
merged 12 commits into from
Nov 14, 2023
Merged

Fix tests for MongoDB with enabled replica set #3604

merged 12 commits into from
Nov 14, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Oct 18, 2023 •
edited
Loading

Description

Closes #3310.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Oct 18, 2023
@rumyantseva rumyantseva self-assigned this Oct 18, 2023
@rumyantseva rumyantseva added this to the Next milestone Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #3604 (1cd38d5) into main (d743808) will decrease coverage by 6.19%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3604      +/-   ##
==========================================
- Coverage   76.82%   70.63%   -6.19%     
==========================================
  Files         323      323              
  Lines       23029    23029              
==========================================
- Hits        17692    16267    -1425     
- Misses       4311     5652    +1341     
- Partials     1026     1110      +84

see 67 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 66.24% <ø> (-6.68%) ⬇️
hana-1 ?
integration 66.24% <ø> (-6.71%) ⬇️
mongodb-1 5.46% <ø> (-0.01%) ⬇️
postgresql-1 ?
postgresql-2 51.63% <ø> (-0.28%) ⬇️
postgresql-3 50.69% <ø> (-0.24%) ⬇️
sort-false 66.24% <ø> (-6.24%) ⬇️
sort-true ?
sqlite-1 ?
sqlite-2 50.90% <ø> (-0.22%) ⬇️
sqlite-3 49.90% <ø> (-0.26%) ⬇️
unit 30.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi modified the milestones: v1.13.0, Next Oct 23, 2023
@AlekSi AlekSi modified the milestones: v1.14.0, Next Nov 7, 2023
@rumyantseva rumyantseva marked this pull request as ready for review November 13, 2023 11:44
@rumyantseva rumyantseva requested review from AlekSi and a team as code owners November 13, 2023 11:44
@rumyantseva rumyantseva enabled auto-merge (squash) November 13, 2023 11:44
@rumyantseva rumyantseva requested review from a team and noisersup November 13, 2023 11:53
noisersup
noisersup approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rumyantseva rumyantseva merged commit 74009c0 into FerretDB:main Nov 14, 2023
25 of 26 checks passed
@rumyantseva rumyantseva deleted the issue-3310-replica-set branch November 14, 2023 08:13
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Nov 16, 2023
@yonarw
Fix tests for MongoDB with enabled replica set (FerretDB#3604)
cc65bec 
Closes FerretDB#3310.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.

Fix tests for MongoDB with enabled replica set
3 participants
@rumyantseva @AlekSi @noisersup