Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Collection.Compact for PostgreSQL #3603

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Implement Collection.Compact for PostgreSQL #3603

merged 4 commits into from
Oct 18, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Oct 18, 2023 •
edited
Loading

Description

Closes #3484.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Oct 18, 2023
@rumyantseva rumyantseva self-assigned this Oct 18, 2023
@rumyantseva rumyantseva added code/chore Code maintenance improvements and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Oct 18, 2023
@rumyantseva rumyantseva added this to the Next milestone Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #3603 (0bf22e5) into main (0d9e48c) will decrease coverage by 0.66%.
The diff coverage is 46.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3603      +/-   ##
==========================================
- Coverage   61.44%   60.78%   -0.66%     
==========================================
  Files         426      426              
  Lines       27473    27502      +29     
==========================================
- Hits        16880    16717     -163     
- Misses       9583     9759     +176     
- Partials     1010     1026      +16
Files Coverage Δ
internal/backends/postgresql/collection.go 63.68% <46.66%> (-0.93%) ⬇️

... and 22 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.10% <0.00%> (-0.87%) ⬇️
hana-1 ?
integration 57.10% <0.00%> (-0.87%) ⬇️
mongodb-1 4.49% <0.00%> (?)
postgresql-1 41.07% <0.00%> (-0.06%) ⬇️
postgresql-2 41.65% <0.00%> (-0.05%) ⬇️
postgresql-3 39.91% <0.00%> (-0.09%) ⬇️
sort-false 57.10% <0.00%> (-0.87%) ⬇️
sqlite-1 ?
sqlite-2 41.82% <0.00%> (-0.05%) ⬇️
sqlite-3 ?
unit 22.49% <46.66%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva requested review from a team, chilagrow and noisersup October 18, 2023 08:36
@rumyantseva rumyantseva marked this pull request as ready for review October 18, 2023 08:36
@rumyantseva rumyantseva requested a review from AlekSi as a code owner October 18, 2023 08:36
@rumyantseva rumyantseva enabled auto-merge (squash) October 18, 2023 08:37
chilagrow
chilagrow approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

noisersup
noisersup approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rumyantseva rumyantseva merged commit 84d054b into FerretDB:main Oct 18, 2023
25 of 26 checks passed
@rumyantseva rumyantseva deleted the issue-3484-compact branch October 18, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Implement Collection.Compact for PostgreSQL
4 participants
@rumyantseva @AlekSi @chilagrow @noisersup