Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make listIndexes return a sorted list #3602

Merged
merged 10 commits into from
Oct 20, 2023
Merged

Make listIndexes return a sorted list #3602

merged 10 commits into from
Oct 20, 2023

Conversation

codenoid
Copy link
Contributor

Description

when doing listIndex, the result now will be sorted in ascending order based on index name

Closes #3589.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codenoid codenoid requested a review from AlekSi as a code owner October 17, 2023 17:43
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #3602 (11ccf37) into main (19c361a) will decrease coverage by 5.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3602      +/-   ##
==========================================
- Coverage   61.62%   56.59%   -5.04%     
==========================================
  Files         427      427              
  Lines       27698    27701       +3     
==========================================
- Hits        17069    15677    -1392     
- Misses       9617    10917    +1300     
- Partials     1012     1107      +95
Files Coverage Δ
internal/backends/collection.go 92.04% <100.00%> (-7.96%) ⬇️
internal/backends/postgresql/collection.go 64.25% <100.00%> (-0.47%) ⬇️
internal/backends/sqlite/collection.go 75.89% <100.00%> (-3.67%) ⬇️

... and 64 files with indirect coverage changes

Flag Coverage Δ
filter-true 52.70% <100.00%> (-5.54%) ⬇️
hana-1 ?
integration 52.70% <100.00%> (-5.54%) ⬇️
mongodb-1 4.47% <0.00%> (-0.01%) ⬇️
postgresql-1 42.28% <70.00%> (-0.02%) ⬇️
postgresql-2 39.80% <70.00%> (-0.01%) ⬇️
postgresql-3 ?
sort-false 52.70% <100.00%> (-5.54%) ⬇️
sqlite-1 42.12% <70.00%> (-0.01%) ⬇️
sqlite-2 ?
sqlite-3 ?
unit 22.69% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@codenoid
Copy link
Contributor Author

actually, I have no clue, should we go for explicit test or functional test

@codenoid codenoid requested a review from a team as a code owner October 18, 2023 18:42
@codenoid codenoid requested review from chilagrow and AlekSi October 18, 2023 18:42
@AlekSi AlekSi added this to the Next milestone Oct 19, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 19, 2023
@AlekSi AlekSi requested review from a team, rumyantseva and noisersup October 19, 2023 05:30
@AlekSi AlekSi changed the title Return sorted list for ListIndexes Make listIndexes return a sorted list Oct 19, 2023
@AlekSi AlekSi enabled auto-merge (squash) October 19, 2023 05:30
rumyantseva
rumyantseva approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AlekSi
AlekSi approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AlekSi AlekSi merged commit 05a2ee3 into FerretDB:main Oct 20, 2023
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@rumyantseva rumyantseva

@codenoid codenoid

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

listIndexes should return a sorted list
3 participants
@codenoid @AlekSi @rumyantseva