Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to run old PG handler #3598

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Make it easier to run old PG handler #3598

merged 4 commits into from
Oct 18, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 17, 2023 •
edited
Loading

Description

Add task run-old and some logging.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements trust PRs that can access Actions secrets packages PRs that should build packages labels Oct 17, 2023
@AlekSi AlekSi self-assigned this Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #3598 (1e622b1) into main (65f5d13) will decrease coverage by 0.11%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3598      +/-   ##
==========================================
- Coverage   61.50%   61.40%   -0.11%     
==========================================
  Files         426      426              
  Lines       27476    27473       -3     
==========================================
- Hits        16899    16869      -30     
- Misses       9569     9597      +28     
+ Partials     1008     1007       -1
Files Coverage Δ
ferretdb/ferretdb.go 82.65% <ø> (-0.69%) ⬇️
integration/setup/listener.go 80.61% <ø> (-2.28%) ⬇️
internal/handlers/registry/registry.go 43.47% <ø> (ø)
internal/handlers/pg/msg_getlog.go 0.00% <0.00%> (ø)
internal/handlers/registry/postgresql.go 50.00% <46.15%> (-10.00%) ⬇️

... and 7 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.92% <42.85%> (-0.09%) ⬇️
hana-1 ?
integration 57.92% <42.85%> (-0.09%) ⬇️
mongodb-1 4.50% <0.00%> (+<0.01%) ⬆️
postgresql-1 41.16% <42.85%> (+0.12%) ⬆️
postgresql-2 41.69% <42.85%> (-0.01%) ⬇️
postgresql-3 39.95% <42.85%> (-0.01%) ⬇️
sort-false 57.92% <42.85%> (-0.09%) ⬇️
sqlite-1 41.06% <0.00%> (+0.09%) ⬆️
sqlite-2 41.87% <0.00%> (+<0.01%) ⬆️
sqlite-3 39.99% <0.00%> (+0.03%) ⬆️
unit 22.37% <42.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Oct 17, 2023
@AlekSi AlekSi removed trust PRs that can access Actions secrets packages PRs that should build packages labels Oct 17, 2023
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup October 17, 2023 11:18
@AlekSi AlekSi marked this pull request as ready for review October 17, 2023 11:18
@AlekSi AlekSi enabled auto-merge (squash) October 17, 2023 11:29
@AlekSi AlekSi added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Oct 17, 2023
rumyantseva
rumyantseva approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 7243c9c into FerretDB:main Oct 18, 2023
25 of 26 checks passed
@AlekSi AlekSi deleted the fix-old-pg branch October 18, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @chilagrow