Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not skip invalid TODOs #3597

Merged
merged 12 commits into from
Oct 18, 2023
Merged

Do not skip invalid TODOs #3597

merged 12 commits into from
Oct 18, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 17, 2023 •
edited
Loading

Description

Closes #2733.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Oct 17, 2023
@mergify mergify bot assigned AlekSi Oct 17, 2023
@AlekSi AlekSi added code/chore Code maintenance improvements and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #3597 (ed78f64) into main (7243c9c) will decrease coverage by 0.12%.
Report is 1 commits behind head on main.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3597      +/-   ##
==========================================
- Coverage   61.52%   61.40%   -0.12%     
==========================================
  Files         426      426              
  Lines       27473    27451      -22     
==========================================
- Hits        16902    16856      -46     
- Misses       9565     9585      +20     
- Partials     1006     1010       +4
Files Coverage Δ
integration/setup/listener.go 80.61% <100.00%> (-2.21%) ⬇️
integration/setup/setup_compat.go 87.09% <ø> (ø)
integration/shareddata/faker.go 0.00% <ø> (ø)
internal/backends/hana/backend.go 0.00% <ø> (-12.50%) ⬇️
...ternal/backends/postgresql/metadata/pool/opendb.go 61.72% <ø> (ø)
internal/backends/postgresql/metadata/pool/pool.go 68.96% <100.00%> (ø)
internal/bson/document.go 51.73% <ø> (ø)
internal/clientconn/conn.go 55.49% <ø> (-0.12%) ⬇️
internal/handlers/common/aggregations/number.go 100.00% <100.00%> (ø)
internal/handlers/common/filter.go 84.34% <ø> (+0.07%) ⬆️
... and 17 more

... and 4 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.91% <64.28%> (-0.13%) ⬇️
hana-1 ?
integration 57.91% <64.28%> (-0.13%) ⬇️
mongodb-1 4.50% <0.00%> (+<0.01%) ⬆️
postgresql-1 41.14% <50.00%> (+0.01%) ⬆️
postgresql-2 41.71% <50.00%> (+0.03%) ⬆️
postgresql-3 39.96% <64.28%> (-0.03%) ⬇️
sort-false 57.91% <64.28%> (-0.13%) ⬇️
sqlite-1 41.05% <35.71%> (-0.01%) ⬇️
sqlite-2 41.89% <35.71%> (+0.02%) ⬆️
sqlite-3 39.98% <50.00%> (-0.02%) ⬇️
unit 22.41% <15.38%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Oct 17, 2023
@AlekSi AlekSi marked this pull request as ready for review October 17, 2023 11:49
@AlekSi AlekSi requested a review from a team as a code owner October 17, 2023 11:49
@AlekSi AlekSi enabled auto-merge (squash) October 17, 2023 11:49
@AlekSi AlekSi requested review from a team and noisersup October 17, 2023 11:49
rumyantseva
rumyantseva previously approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi requested review from a team October 18, 2023 10:11
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Oct 18, 2023
@AlekSi
Copy link
Member Author

AlekSi commented Oct 18, 2023

Blocked by FerretDB/github-actions#217

noisersup
noisersup previously approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

integration/create_test.go Show resolved Hide resolved
rumyantseva
rumyantseva previously approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi dismissed stale reviews from rumyantseva and noisersup via edb8935 October 18, 2023 14:12
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Oct 18, 2023
@AlekSi AlekSi requested review from rumyantseva, noisersup and a team October 18, 2023 14:16
@AlekSi AlekSi disabled auto-merge October 18, 2023 14:41
@AlekSi AlekSi merged commit f1b8354 into FerretDB:main Oct 18, 2023
24 of 42 checks passed
@AlekSi AlekSi deleted the todos branch October 18, 2023 14:41
@AlekSi
Copy link
Member Author

AlekSi commented Oct 18, 2023

Merged to unblock all other PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow Awaiting requested review from chilagrow

@rumyantseva rumyantseva Awaiting requested review from rumyantseva

@noisersup noisersup Awaiting requested review from noisersup

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Make linter for checking that linked issues are open
4 participants
@AlekSi @rumyantseva @chilagrow @noisersup