Remove done TODO #3596
Merged
Remove done TODO #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3596 +/- ##
==========================================
- Coverage 61.65% 61.50% -0.15%
==========================================
Files 426 426
Lines 27395 27399 +4
==========================================
- Hits 16890 16852 -38
- Misses 9506 9542 +36
- Partials 999 1005 +6
... and 27 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
commented
Oct 17, 2023
| @@ -185,8 +185,6 @@ func (h *Handler) MsgAggregate(ctx context.Context, msg *wire.OpMsg) (*wire.OpMs | |||
| switch d.Command() { | |||
| case "$collStats": | |||
| if i > 0 { | |||
| // Add a test to cover this error. | |||
| // TODO https://github.com/FerretDB/FerretDB/issues/2349 | |||
There was a problem hiding this comment.
AlekSi
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2349.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.