Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old TODOs #3595

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Remove old TODOs #3595

merged 2 commits into from
Oct 17, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 17, 2023

Description

As detected by #3277.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #3595 (7307819) into main (eb63b11) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3595      +/-   ##
==========================================
- Coverage   61.62%   61.50%   -0.13%     
==========================================
  Files         426      426              
  Lines       27401    27401              
==========================================
- Hits        16887    16854      -33     
- Misses       9511     9543      +32     
- Partials     1003     1004       +1     
Files Coverage Δ
internal/backends/sqlite/collection.go 74.63% <ø> (+0.86%) ⬆️
internal/handlers/common/filter.go 84.27% <ø> (ø)
internal/types/compare_order.go 83.09% <ø> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
filter-true 58.06% <ø> (-0.12%) ⬇️
hana-1 ?
integration 58.06% <ø> (-0.12%) ⬇️
mongodb-1 4.50% <ø> (ø)
postgresql-1 41.13% <ø> (ø)
postgresql-2 41.80% <ø> (+0.01%) ⬆️
postgresql-3 40.05% <ø> (-0.05%) ⬇️
sort-false 58.06% <ø> (-0.12%) ⬇️
sqlite-1 41.16% <ø> (+0.04%) ⬆️
sqlite-2 41.96% <ø> (ø)
sqlite-3 40.09% <ø> (+0.02%) ⬆️
unit 22.40% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 17, 2023
@AlekSi AlekSi marked this pull request as ready for review October 17, 2023 06:50
@AlekSi AlekSi requested a review from a team as a code owner October 17, 2023 06:50
@AlekSi AlekSi enabled auto-merge (squash) October 17, 2023 06:50
@AlekSi AlekSi requested review from a team and noisersup October 17, 2023 06:50
@AlekSi AlekSi added this to the Next milestone Oct 17, 2023
@AlekSi AlekSi disabled auto-merge October 17, 2023 07:23
@AlekSi AlekSi merged commit 2940296 into FerretDB:main Oct 17, 2023
28 of 29 checks passed
@AlekSi AlekSi deleted the todos branch October 17, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants