Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement free storage in collStats, dbStats and aggregate $collStats #3594

Merged
merged 17 commits into from
Oct 18, 2023
Merged

Implement free storage in collStats, dbStats and aggregate $collStats #3594

merged 17 commits into from
Oct 18, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Oct 17, 2023 •
edited
Loading

Description

Closes #2342.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/feature Some user-visible feature is not implemented yet label Oct 17, 2023
@chilagrow chilagrow added this to the Next milestone Oct 17, 2023
@chilagrow chilagrow self-assigned this Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #3594 (a828a3c) into main (f433e25) will decrease coverage by 0.13%.
The diff coverage is 86.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3594      +/-   ##
==========================================
- Coverage   61.75%   61.62%   -0.13%     
==========================================
  Files         426      426              
  Lines       27528    27584      +56     
==========================================
- Hits        16999    16998       -1     
- Misses       9522     9570      +48     
- Partials     1007     1016       +9
Files Coverage Δ
internal/backends/collection.go 100.00% <ø> (ø)
internal/backends/database.go 97.26% <ø> (ø)
internal/backends/postgresql/collection.go 64.56% <100.00%> (+0.08%) ⬆️
internal/backends/sqlite/collection.go 79.12% <100.00%> (-0.77%) ⬇️
internal/backends/sqlite/database.go 76.40% <100.00%> (+0.26%) ⬆️
internal/handlers/sqlite/msg_aggregate.go 87.10% <100.00%> (+0.03%) ⬆️
internal/handlers/sqlite/msg_collstats.go 68.14% <100.00%> (+3.43%) ⬆️
internal/backends/postgresql/database.go 67.96% <80.00%> (-0.62%) ⬇️
internal/backends/postgresql/postgresql.go 76.92% <50.00%> (+0.60%) ⬆️
internal/handlers/sqlite/msg_dbstats.go 69.64% <89.28%> (+6.54%) ⬆️
... and 1 more

... and 8 files with indirect coverage changes

Flag Coverage Δ
filter-true 58.22% <86.07%> (-0.12%) ⬇️
hana-1 ?
integration 58.22% <86.07%> (-0.12%) ⬇️
mongodb-1 4.49% <0.00%> (+<0.01%) ⬆️
postgresql-1 42.46% <53.16%> (+2.95%) ⬆️
postgresql-2 39.84% <67.08%> (-2.13%) ⬇️
postgresql-3 41.83% <67.08%> (-0.98%) ⬇️
sort-false 58.22% <86.07%> (-0.12%) ⬇️
sqlite-1 42.27% <58.22%> (+2.86%) ⬆️
sqlite-2 39.26% <72.15%> (-1.95%) ⬇️
sqlite-3 41.52% <72.15%> (-0.75%) ⬇️
unit 22.68% <32.91%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review October 18, 2023 07:39
@chilagrow chilagrow requested review from AlekSi and a team as code owners October 18, 2023 07:39
@chilagrow chilagrow requested a review from rumyantseva October 18, 2023 07:39
@chilagrow chilagrow enabled auto-merge (squash) October 18, 2023 07:39
@chilagrow chilagrow requested review from a team and noisersup October 18, 2023 07:39
@chilagrow chilagrow force-pushed the issue-2342-stats-free-storage branch from 486edda to bf8c849 Compare October 18, 2023 09:26
rumyantseva
rumyantseva approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chilagrow chilagrow merged commit e82aefb into FerretDB:main Oct 18, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Implement missing fields for storageStats in $collStats aggregation pipeline stage
3 participants
@chilagrow @AlekSi @rumyantseva