Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve /debug page #3592

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Improve /debug page #3592

merged 6 commits into from
Oct 17, 2023

Conversation

codenoid
Copy link
Contributor

Description

Add description to each handler

image

Closes #3583 .

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codenoid codenoid requested a review from a team as a code owner October 16, 2023 20:11
@codenoid codenoid requested review from AlekSi and chilagrow October 16, 2023 20:11
@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 17, 2023
@AlekSi AlekSi changed the title debug page: add description of each handler Improve /debug page Oct 17, 2023
@AlekSi AlekSi added this to the Next milestone Oct 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2023

@codenoid this pull request has merge conflicts.

AlekSi
AlekSi reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's resolve the conflict with the previous PR

@mergify mergify bot added the conflict PRs that have merge conflicts label Oct 17, 2023
@AlekSi AlekSi added the community Issues and PRs assigned to community members label Oct 17, 2023
@AlekSi AlekSi self-assigned this Oct 17, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #3592 (d7437fe) into main (a7cc841) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3592      +/-   ##
==========================================
- Coverage   61.49%   61.39%   -0.10%     
==========================================
  Files         426      426              
  Lines       27474    27478       +4     
==========================================
- Hits        16894    16869      -25     
- Misses       9574     9600      +26     
- Partials     1006     1009       +3
Files Coverage Δ
internal/util/debug/debug.go 88.23% <100.00%> (+0.73%) ⬆️

... and 12 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.91% <100.00%> (-0.08%) ⬇️
hana-1 ?
integration 57.91% <100.00%> (-0.08%) ⬇️
mongodb-1 4.50% <100.00%> (?)
postgresql-1 41.07% <100.00%> (-0.14%) ⬇️
postgresql-2 41.69% <100.00%> (+<0.01%) ⬆️
postgresql-3 39.95% <100.00%> (+0.01%) ⬆️
sort-false 57.91% <100.00%> (-0.08%) ⬇️
sqlite-1 40.94% <100.00%> (-0.12%) ⬇️
sqlite-2 41.86% <100.00%> (+<0.01%) ⬆️
sqlite-3 40.00% <100.00%> (+<0.01%) ⬆️
unit 22.38% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi self-requested a review October 17, 2023 12:45
@AlekSi AlekSi enabled auto-merge (squash) October 17, 2023 12:46
@AlekSi AlekSi disabled auto-merge October 17, 2023 13:26
@AlekSi AlekSi merged commit d8ac329 into FerretDB:main Oct 17, 2023
27 checks passed
@AlekSi
Copy link
Member

AlekSi commented Oct 17, 2023 •
edited
Loading

Thank you! Want to take on #3600 next? Ok, you already picked another one.

@codenoid codenoid deleted the improve-debug-page branch October 17, 2023 17:08
@AlekSi AlekSi added code/enhancement Some user-visible feature could work better and removed code/chore Code maintenance improvements labels Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

@codenoid codenoid

Labels
code/enhancement Some user-visible feature could work better community Issues and PRs assigned to community members
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Improve /debug page
2 participants
@codenoid @AlekSi