Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not return stats in Backend.ListDatabases #3588

Merged
merged 13 commits into from
Oct 17, 2023
Merged

Do not return stats in Backend.ListDatabases #3588

merged 13 commits into from
Oct 17, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 16, 2023 •
edited
Loading

Description

Most callers do not need it.
Also, ensure that lists are sorted and use binary search.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi
Do not return stats in Backend.ListDatabases
1943124 
Most callers do not need it.
@mergify mergify bot assigned AlekSi Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #3588 (f9a16c1) into main (c3888f1) will decrease coverage by 0.43%.
The diff coverage is 86.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3588      +/-   ##
==========================================
- Coverage   61.64%   61.22%   -0.43%     
==========================================
  Files         426      426              
  Lines       27403    27395       -8     
==========================================
- Hits        16893    16773     -120     
- Misses       9509     9609     +100     
- Partials     1001     1013      +12
Files Coverage Δ
internal/backends/backend.go 93.10% <100.00%> (+0.51%) ⬆️
internal/backends/collection.go 92.30% <100.00%> (+0.64%) ⬆️
internal/backends/database.go 97.26% <100.00%> (+0.15%) ⬆️
internal/backends/postgresql/backend.go 60.25% <ø> (+5.81%) ⬆️
internal/backends/postgresql/collection.go 68.66% <ø> (ø)
internal/backends/sqlite/backend.go 72.88% <ø> (+9.50%) ⬆️
internal/backends/sqlite/collection.go 72.33% <ø> (-2.31%) ⬇️
internal/handlers/sqlite/msg_aggregate.go 87.06% <100.00%> (+0.70%) ⬆️
internal/handlers/sqlite/msg_collstats.go 64.70% <100.00%> (-1.34%) ⬇️
internal/handlers/sqlite/msg_listdatabases.go 69.33% <68.42%> (-4.91%) ⬇️

... and 15 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.77% <79.06%> (-0.40%) ⬇️
hana-1 ?
integration 57.77% <79.06%> (-0.40%) ⬇️
mongodb-1 4.47% <0.00%> (+<0.01%) ⬆️
postgresql-1 41.21% <65.11%> (-0.04%) ⬇️
postgresql-2 41.78% <79.06%> (+0.04%) ⬆️
postgresql-3 40.04% <65.11%> (-0.07%) ⬇️
sort-false 57.77% <79.06%> (-0.40%) ⬇️
sort-true ?
sqlite-1 ?
sqlite-2 41.95% <79.06%> (+0.05%) ⬆️
sqlite-3 40.08% <65.11%> (-0.01%) ⬇️
unit 22.41% <11.62%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Oct 16, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 16, 2023
@AlekSi AlekSi marked this pull request as ready for review October 16, 2023 12:39
@AlekSi AlekSi requested a review from a team as a code owner October 16, 2023 12:39
@AlekSi AlekSi enabled auto-merge (squash) October 16, 2023 12:39
@AlekSi AlekSi requested review from a team and noisersup October 16, 2023 12:39
rumyantseva
rumyantseva approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi mentioned this pull request Oct 16, 2023
Merged
9 tasks
@AlekSi AlekSi merged commit 6131bf4 into FerretDB:main Oct 17, 2023
26 checks passed
@AlekSi AlekSi deleted the analyze branch October 17, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @chilagrow