Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pgdb from envtool #3586

Merged
merged 11 commits into from
Oct 27, 2023
Merged

Remove pgdb from envtool #3586

merged 11 commits into from
Oct 27, 2023

Conversation

ShatilKhan
Copy link
Contributor

@ShatilKhan ShatilKhan commented Oct 16, 2023 •
edited by noisersup
Loading

Description

Removed pgdb from envtool.go file

Closes #3452

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@ShatilKhan ShatilKhan requested a review from a team as a code owner October 16, 2023 09:48
@CLAassistant
Copy link

CLAassistant commented Oct 16, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 16, 2023
AlekSi
AlekSi reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please click the CLA button in that comment: #3586 (comment)

cmd/envtool/envtool.go Show resolved Hide resolved
@AlekSi AlekSi assigned noisersup and unassigned ShatilKhan Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited
Loading

Codecov Report

Merging #3586 (01023f0) into main (b734008) will decrease coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3586      +/-   ##
==========================================
- Coverage   62.62%   61.98%   -0.64%     
==========================================
  Files         430      430              
  Lines       27906    27906              
==========================================
- Hits        17476    17298     -178     
- Misses       9411     9572     +161     
- Partials     1019     1036      +17

see 18 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 58.62% <ø> (-0.62%) ⬇️
hana-1 ?
integration 58.62% <ø> (-0.64%) ⬇️
mongodb-1 4.46% <ø> (ø)
postgresql-1 42.96% <ø> (-0.30%) ⬇️
postgresql-2 40.29% <ø> (-0.33%) ⬇️
postgresql-3 42.58% <ø> (-0.31%) ⬇️
sort-false 58.62% <ø> (-0.20%) ⬇️
sort-true ?
sqlite-1 42.37% <ø> (-0.19%) ⬇️
sqlite-2 39.73% <ø> (-0.23%) ⬇️
sqlite-3 41.98% <ø> (-0.45%) ⬇️
unit 22.79% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup enabled auto-merge (squash) October 24, 2023 12:20
@noisersup noisersup requested a review from AlekSi October 24, 2023 12:20
@noisersup noisersup added this to the Next milestone Oct 24, 2023
@noisersup noisersup requested review from a team, rumyantseva and noisersup October 24, 2023 12:21
@AlekSi AlekSi disabled auto-merge October 24, 2023 15:51
@AlekSi AlekSi enabled auto-merge (squash) October 24, 2023 15:51
AlekSi
AlekSi reviewed Oct 24, 2023
View reviewed changes
cmd/envtool/envtool.go Outdated Show resolved Hide resolved
@noisersup noisersup requested a review from AlekSi October 25, 2023 21:05
chilagrow
chilagrow reviewed Oct 26, 2023
View reviewed changes
cmd/envtool/envtool.go Outdated Show resolved Hide resolved
cmd/envtool/envtool.go Outdated Show resolved Hide resolved
@noisersup noisersup requested a review from chilagrow October 26, 2023 16:21
chilagrow
chilagrow previously approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 🤗

AlekSi
AlekSi reviewed Oct 27, 2023
View reviewed changes
cmd/envtool/envtool.go Outdated Show resolved Hide resolved
@noisersup noisersup requested review from AlekSi and chilagrow October 27, 2023 12:30
@AlekSi AlekSi disabled auto-merge October 27, 2023 12:56
@AlekSi AlekSi changed the title Remove pgdb from envtool.go Remove pgdb from envtool Oct 27, 2023
@AlekSi AlekSi enabled auto-merge (squash) October 27, 2023 12:56
@AlekSi AlekSi disabled auto-merge October 27, 2023 13:25
@AlekSi AlekSi merged commit 2715338 into FerretDB:main Oct 27, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@chilagrow chilagrow Awaiting requested review from chilagrow

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.

Remove pgdb from envtool
5 participants
@ShatilKhan @CLAassistant @AlekSi @chilagrow @noisersup