Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dataSize and dbStats integration tests #3585

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Update dataSize and dbStats integration tests #3585

merged 3 commits into from
Oct 17, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Oct 16, 2023 •
edited
Loading

Description

Closes #727.
Closes #2447.

Keep #2447 open.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Oct 16, 2023
@chilagrow chilagrow added this to the Next milestone Oct 16, 2023
@chilagrow chilagrow self-assigned this Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #3585 (dda6325) into main (11ae05e) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3585      +/-   ##
==========================================
- Coverage   61.63%   61.47%   -0.17%     
==========================================
  Files         426      426              
  Lines       27403    27403              
==========================================
- Hits        16890    16846      -44     
- Misses       9511     9550      +39     
- Partials     1002     1007       +5

see 8 files with indirect coverage changes

Flag Coverage Δ
filter-true 58.03% <ø> (-0.15%) ⬇️
hana-1 ?
integration 58.03% <ø> (-0.15%) ⬇️
mongodb-1 4.47% <ø> (ø)
postgresql-1 41.20% <ø> (+0.04%) ⬆️
postgresql-2 41.73% <ø> (+<0.01%) ⬆️
postgresql-3 40.03% <ø> (ø)
sort-false 58.03% <ø> (-0.15%) ⬇️
sqlite-1 41.14% <ø> (-0.01%) ⬇️
sqlite-2 41.90% <ø> (ø)
sqlite-3 40.08% <ø> (-0.02%) ⬇️
unit 22.41% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review October 16, 2023 07:35
@chilagrow chilagrow requested a review from a team as a code owner October 16, 2023 07:35
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team and noisersup October 16, 2023 07:35
@chilagrow chilagrow enabled auto-merge (squash) October 16, 2023 07:36
@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2023

@chilagrow this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Oct 16, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Oct 16, 2023
rumyantseva
rumyantseva approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow merged commit c3888f1 into FerretDB:main Oct 17, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
3 participants
@chilagrow @AlekSi @rumyantseva