Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable linters to accept exclamation marks in headers #3578

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Enable linters to accept exclamation marks in headers #3578

merged 3 commits into from
Oct 18, 2023

Conversation

chanon-mike
Copy link
Contributor

Description

Closes #3564.

Enable linter to accept exclamation mark in markdown file.

Test by

  • cd build from root directory
  • echo "Exciting times at FerretDB!" >> ./test.md to create test markdown file with exclamation mark header
  • markdownlint-cli2 test.md test markdown file and error does not appear

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chanon-mike chanon-mike requested a review from AlekSi as a code owner October 14, 2023 10:11
@CLAassistant
Copy link

CLAassistant commented Oct 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 14, 2023 •
edited
Loading

Codecov Report

Merging #3578 (c84ae4a) into main (7243c9c) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3578      +/-   ##
==========================================
- Coverage   61.52%   61.41%   -0.11%     
==========================================
  Files         426      426              
  Lines       27473    27473              
==========================================
- Hits        16902    16873      -29     
- Misses       9565     9594      +29     
  Partials     1006     1006

see 6 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.92% <ø> (-0.11%) ⬇️
hana-1 ?
integration 57.92% <ø> (-0.11%) ⬇️
mongodb-1 4.50% <ø> (ø)
postgresql-1 41.06% <ø> (-0.07%) ⬇️
postgresql-2 41.67% <ø> (-0.01%) ⬇️
postgresql-3 39.95% <ø> (-0.05%) ⬇️
sort-false 57.92% <ø> (-0.11%) ⬇️
sqlite-1 41.00% <ø> (-0.05%) ⬇️
sqlite-2 41.86% <ø> (-0.01%) ⬇️
sqlite-3 39.99% <ø> (ø)
unit 22.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi requested review from a team and Fashander October 16, 2023 05:56
@Fashander Fashander enabled auto-merge (squash) October 18, 2023 01:18
@AlekSi AlekSi added the documentation Something user-visible is badly or not documented label Oct 18, 2023
@AlekSi AlekSi added this to the Next milestone Oct 18, 2023
AlekSi
AlekSi approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Fashander Fashander merged commit d7493f7 into FerretDB:main Oct 18, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fashander Fashander Fashander approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@Fashander Fashander

@chanon-mike chanon-mike

Labels
documentation Something user-visible is badly or not documented
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Enable linters to accept exclamation marks in headers
4 participants
@chanon-mike @CLAassistant @AlekSi @Fashander