Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build arm/v7 binaries #3577

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Build arm/v7 binaries #3577

merged 5 commits into from
Oct 13, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 13, 2023 •
edited
Loading

Description

Also DRY build a bit.

Refs #3576.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements trust PRs that can access Actions secrets packages PRs that should build packages labels Oct 13, 2023
@AlekSi AlekSi self-assigned this Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Merging #3577 (041dd01) into main (5d4a0d2) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3577      +/-   ##
==========================================
+ Coverage   61.12%   61.23%   +0.11%     
==========================================
  Files         426      426              
  Lines       27207    27207              
==========================================
+ Hits        16631    16661      +30     
+ Misses       9588     9555      -33     
- Partials      988      991       +3

see 15 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.73% <ø> (+0.10%) ⬆️
hana-1 2.89% <ø> (ø)
integration 57.73% <ø> (+0.10%) ⬆️
mongodb-1 4.51% <ø> (ø)
postgresql-1 41.06% <ø> (-0.07%) ⬇️
postgresql-2 40.66% <ø> (ø)
postgresql-3 39.53% <ø> (-0.01%) ⬇️
sort-false 57.73% <ø> (+0.10%) ⬆️
sqlite-1 41.03% <ø> (-0.01%) ⬇️
sqlite-2 ?
sqlite-3 39.45% <ø> (?)
unit 22.37% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Oct 13, 2023
@AlekSi AlekSi marked this pull request as ready for review October 13, 2023 09:14
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup October 13, 2023 09:15
@AlekSi AlekSi enabled auto-merge (squash) October 13, 2023 10:06
rumyantseva
rumyantseva approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 30a1c91 into FerretDB:main Oct 13, 2023
24 of 26 checks passed
@AlekSi AlekSi deleted the refactor-build branch October 13, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements packages PRs that should build packages trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @noisersup