Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement indexSizes for collStats #3575

Merged
merged 18 commits into from
Oct 16, 2023
Merged

Implement indexSizes for collStats #3575

merged 18 commits into from
Oct 16, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Oct 13, 2023 •
edited
Loading

Description

Closes #2447.
Closes #2342.

Keep #2447 open.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/enhancement Some user-visible feature could work better label Oct 13, 2023
@chilagrow chilagrow added this to the Next milestone Oct 13, 2023
@chilagrow chilagrow self-assigned this Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Merging #3575 (55ff696) into main (b444693) will increase coverage by 0.01%.
The diff coverage is 77.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3575      +/-   ##
==========================================
+ Coverage   61.46%   61.48%   +0.01%     
==========================================
  Files         426      426              
  Lines       27298    27403     +105     
==========================================
+ Hits        16780    16848      +68     
- Misses       9518     9549      +31     
- Partials     1000     1006       +6
Files Coverage Δ
internal/backends/collection.go 91.66% <ø> (ø)
...l/handlers/common/aggregations/stages/collstats.go 87.50% <100.00%> (+1.56%) ⬆️
internal/handlers/sqlite/msg_aggregate.go 86.36% <100.00%> (+0.15%) ⬆️
internal/handlers/sqlite/msg_collstats.go 66.03% <100.00%> (+1.68%) ⬆️
internal/backends/postgresql/collection.go 68.66% <70.73%> (+0.27%) ⬆️
internal/backends/sqlite/collection.go 74.63% <74.46%> (-0.03%) ⬇️

... and 11 files with indirect coverage changes

Flag Coverage Δ
filter-true 58.03% <77.57%> (+0.03%) ⬆️
hana-1 ?
integration 58.03% <77.57%> (+0.03%) ⬆️
mongodb-1 4.47% <0.00%> (-0.02%) ⬇️
postgresql-1 41.15% <44.85%> (+0.38%) ⬆️
postgresql-2 41.72% <36.44%> (+0.23%) ⬆️
postgresql-3 40.04% <44.85%> (+0.48%) ⬆️
sort-false 58.03% <77.57%> (+0.03%) ⬆️
sqlite-1 41.05% <50.46%> (+0.60%) ⬆️
sqlite-2 41.89% <42.05%> (+0.06%) ⬆️
sqlite-3 40.08% <50.46%> (+0.36%) ⬆️
unit 22.42% <59.81%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review October 13, 2023 05:25
@chilagrow chilagrow requested review from AlekSi and a team as code owners October 13, 2023 05:25
@chilagrow chilagrow requested review from rumyantseva, a team and noisersup October 13, 2023 05:25
@chilagrow chilagrow enabled auto-merge (squash) October 13, 2023 05:25
@chilagrow chilagrow mentioned this pull request Oct 16, 2023
Open
@chilagrow chilagrow requested a review from AlekSi October 16, 2023 06:17
@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2023

@chilagrow this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Oct 16, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Oct 16, 2023
rumyantseva
rumyantseva approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow merged commit 11ae05e into FerretDB:main Oct 16, 2023
35 of 49 checks passed
@AlekSi AlekSi added code/feature Some user-visible feature is not implemented yet and removed code/enhancement Some user-visible feature could work better labels Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
3 participants
@chilagrow @AlekSi @rumyantseva