Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create databases during local setup #3572

Merged
merged 7 commits into from
Oct 13, 2023
Merged

Do not create databases during local setup #3572

merged 7 commits into from
Oct 13, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 12, 2023

Description

They are not compatible with the new PostgreSQL backend.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

AlekSi added 2 commits October 12, 2023 21:32
@AlekSi
Do not create databases during local setup
89b0c7c 
They are not compatible with the new PostgreSQL backend.
@AlekSi
Add TODO
11827b6
@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 12, 2023
@AlekSi AlekSi added this to the Next milestone Oct 12, 2023
@AlekSi AlekSi self-assigned this Oct 12, 2023
@AlekSi AlekSi requested a review from a team as a code owner October 12, 2023 17:34
@AlekSi AlekSi enabled auto-merge (squash) October 12, 2023 17:34
@AlekSi AlekSi requested review from a team and noisersup October 12, 2023 17:34
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #3572 (931a855) into main (06681c6) will decrease coverage by 0.40%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3572      +/-   ##
==========================================
- Coverage   61.42%   61.03%   -0.40%     
==========================================
  Files         426      426              
  Lines       27200    27207       +7     
==========================================
- Hits        16707    16605     -102     
- Misses       9503     9603     +100     
- Partials      990      999       +9
Files Coverage Δ
internal/backends/collection.go 91.66% <ø> (ø)
internal/backends/postgresql/query.go 82.60% <100.00%> (+0.12%) ⬆️
internal/handlers/common/delete_params.go 100.00% <ø> (ø)
internal/handlers/common/update_params.go 100.00% <ø> (ø)
internal/handlers/pg/msg_delete.go 0.00% <ø> (ø)
internal/handlers/sqlite/msg_find.go 80.86% <66.66%> (-1.54%) ⬇️

... and 14 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.52% <70.00%> (-0.43%) ⬇️
hana-1 ?
integration 57.52% <70.00%> (-0.43%) ⬇️
mongodb-1 4.51% <0.00%> (-0.01%) ⬇️
postgresql-1 41.16% <70.00%> (+0.04%) ⬆️
postgresql-2 40.66% <70.00%> (+<0.01%) ⬆️
postgresql-3 39.54% <70.00%> (+<0.01%) ⬆️
sort-false 57.52% <70.00%> (-0.43%) ⬇️
sqlite-1 ∅ <ø> (∅)
sqlite-2 41.19% <60.00%> (+<0.01%) ⬆️
sqlite-3 39.45% <60.00%> (+<0.01%) ⬆️
unit 22.39% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Oct 13, 2023
@AlekSi AlekSi merged commit 5d4a0d2 into FerretDB:main Oct 13, 2023
56 of 73 checks passed
@AlekSi AlekSi deleted the envtool branch October 13, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @chilagrow