Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SQLite directory for Docker images #3571

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Change SQLite directory for Docker images #3571

merged 4 commits into from
Oct 13, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 12, 2023

Description

Makes them easier to use.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added documentation Something user-visible is badly or not documented code/chore Code maintenance improvements trust PRs that can access Actions secrets packages PRs that should build packages labels Oct 12, 2023
@AlekSi AlekSi added this to the Next milestone Oct 12, 2023
@AlekSi AlekSi self-assigned this Oct 12, 2023
@AlekSi AlekSi requested a review from ptrfarkas as a code owner October 12, 2023 14:58
@AlekSi AlekSi enabled auto-merge (squash) October 12, 2023 14:58
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #3571 (5a7e737) into main (633b827) will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3571      +/-   ##
==========================================
- Coverage   61.39%   61.12%   -0.27%     
==========================================
  Files         426      426              
  Lines       27200    27200              
==========================================
- Hits        16700    16627      -73     
- Misses       9508     9575      +67     
- Partials      992      998       +6

see 7 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.61% <ø> (-0.30%) ⬇️
hana-1 2.89% <ø> (ø)
integration 57.61% <ø> (-0.30%) ⬇️
mongodb-1 4.51% <ø> (ø)
postgresql-1 41.12% <ø> (ø)
postgresql-2 40.65% <ø> (ø)
postgresql-3 39.53% <ø> (+<0.01%) ⬆️
sort-false 57.61% <ø> (-0.30%) ⬇️
sqlite-1 ?
sqlite-2 41.18% <ø> (ø)
sqlite-3 39.44% <ø> (-0.01%) ⬇️
unit 22.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi mentioned this pull request Oct 13, 2023
Merged
9 tasks
rumyantseva
rumyantseva approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 06681c6 into FerretDB:main Oct 13, 2023
33 of 42 checks passed
@AlekSi AlekSi deleted the sqlite-default branch October 13, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptrfarkas ptrfarkas ptrfarkas approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@Fashander Fashander Awaiting requested review from Fashander Fashander was automatically assigned from FerretDB/docs

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements documentation Something user-visible is badly or not documented packages PRs that should build packages trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AlekSi @rumyantseva @chilagrow @ptrfarkas