Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report actual backend name #3570

Merged
merged 8 commits into from
Oct 13, 2023
Merged

Report actual backend name #3570

merged 8 commits into from
Oct 13, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 12, 2023 •
edited
Loading

Description

Store the backend's name in the state and make it dynamic to handle PostgreSQL-compatible systems.
Add it to metrics, log messages, etc.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 12, 2023
@AlekSi AlekSi added this to the Next milestone Oct 12, 2023
@AlekSi AlekSi self-assigned this Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #3570 (a7148c4) into main (52fe847) will decrease coverage by 0.35%.
The diff coverage is 78.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3570      +/-   ##
==========================================
- Coverage   61.48%   61.14%   -0.35%     
==========================================
  Files         426      426              
  Lines       27200    27200              
==========================================
- Hits        16725    16631      -94     
- Misses       9493     9572      +79     
- Partials      982      997      +15
Files Coverage Δ
integration/setup/listener.go 79.38% <100.00%> (ø)
internal/backends/backend.go 92.59% <ø> (-0.27%) ⬇️
internal/backends/decorators/dummy/backend.go 0.00% <ø> (ø)
internal/backends/decorators/oplog/backend.go 0.00% <ø> (ø)
internal/backends/hana/backend.go 12.50% <ø> (+1.38%) ⬆️
internal/backends/postgresql/backend.go 57.31% <ø> (-1.02%) ⬇️
internal/backends/sqlite/backend.go 67.74% <ø> (-1.01%) ⬇️
internal/handlers/sqlite/msg_getlog.go 81.65% <100.00%> (+0.16%) ⬆️
internal/util/state/metrics.go 100.00% <100.00%> (ø)
internal/util/state/state.go 100.00% <100.00%> (ø)
... and 5 more

... and 12 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.64% <48.27%> (-0.36%) ⬇️
hana-1 2.89% <6.89%> (-0.01%) ⬇️
integration 57.64% <48.27%> (-0.36%) ⬇️
mongodb-1 4.51% <0.00%> (-0.01%) ⬇️
postgresql-1 41.06% <20.68%> (-0.09%) ⬇️
postgresql-2 40.65% <20.68%> (+<0.01%) ⬆️
postgresql-3 39.53% <37.93%> (-0.01%) ⬇️
sort-false 57.64% <48.27%> (-0.36%) ⬇️
sqlite-1 ?
sqlite-2 41.18% <24.13%> (+<0.01%) ⬆️
sqlite-3 39.49% <31.03%> (-0.01%) ⬇️
unit 22.38% <61.29%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added code/enhancement Some user-visible feature could work better and removed code/chore Code maintenance improvements labels Oct 12, 2023
@AlekSi AlekSi changed the title Simplify backend's version handling Report actual backend name Oct 12, 2023
@AlekSi AlekSi marked this pull request as ready for review October 12, 2023 13:26
@AlekSi AlekSi requested a review from a team as a code owner October 12, 2023 13:26
@AlekSi AlekSi enabled auto-merge (squash) October 12, 2023 13:27
@AlekSi AlekSi requested review from a team and noisersup October 12, 2023 13:27
@AlekSi AlekSi added trust PRs that can access Actions secrets packages PRs that should build packages not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Oct 12, 2023
rumyantseva
rumyantseva approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit 633b827 into FerretDB:main Oct 13, 2023
25 of 26 checks passed
@AlekSi AlekSi deleted the backend-name branch October 13, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/enhancement Some user-visible feature could work better packages PRs that should build packages trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @chilagrow