Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SQLite set up docs #3568

Merged
merged 12 commits into from
Oct 19, 2023
Merged

Add SQLite set up docs #3568

merged 12 commits into from
Oct 19, 2023

Conversation

Fashander
Copy link
Member

Description

Closes #3369.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@Fashander Fashander added the documentation Something user-visible is badly or not documented label Oct 12, 2023
@Fashander Fashander added this to the Next milestone Oct 12, 2023
@Fashander Fashander requested a review from a team October 12, 2023 10:58
@Fashander Fashander self-assigned this Oct 12, 2023
@Fashander Fashander enabled auto-merge (squash) October 12, 2023 10:58
@AlekSi AlekSi added the trust PRs that can access Actions secrets label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #3568 (6c50af7) into main (e82aefb) will decrease coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3568      +/-   ##
==========================================
- Coverage   61.82%   61.45%   -0.38%     
==========================================
  Files         426      426              
  Lines       27584    27584              
==========================================
- Hits        17054    16951     -103     
- Misses       9523     9608      +85     
- Partials     1007     1025      +18

see 13 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.92% <ø> (-0.46%) ⬇️
hana-1 3.01% <ø> (ø)
integration 57.92% <ø> (-0.46%) ⬇️
mongodb-1 4.49% <ø> (ø)
postgresql-1 42.47% <ø> (ø)
postgresql-2 39.85% <ø> (ø)
postgresql-3 41.92% <ø> (-0.02%) ⬇️
sort-false 57.92% <ø> (-0.46%) ⬇️
sqlite-1 42.27% <ø> (ø)
sqlite-2 ?
sqlite-3 ?
unit 22.69% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Fashander Fashander requested a review from AlekSi October 12, 2023 15:45
noisersup
noisersup reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The #3571 is merged, we're ready to remove the variable, apart from that LGTM

@Fashander Fashander requested review from noisersup and AlekSi October 18, 2023 11:26
noisersup
noisersup previously approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Fashander @AlekSi
Update website/docs/quickstart-guide/docker.md
c63cf92 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@Fashander Fashander requested review from AlekSi and noisersup October 18, 2023 16:12
@AlekSi AlekSi requested review from a team, rumyantseva and chilagrow October 18, 2023 16:16
@AlekSi AlekSi added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Oct 18, 2023
chilagrow
chilagrow approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Fashander Fashander merged commit 9a56544 into FerretDB:main Oct 19, 2023
25 of 26 checks passed
@Fashander Fashander deleted the sqlite-docs branch December 4, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@noisersup noisersup Awaiting requested review from noisersup

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

Assignees

@Fashander Fashander

Labels
documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Add SQLite backend set up to documentation
4 participants
@Fashander @AlekSi @chilagrow @noisersup