Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capped collection counts in serverStatus #3566

Merged
merged 9 commits into from
Oct 13, 2023
Merged

Add capped collection counts in serverStatus #3566

merged 9 commits into from
Oct 13, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Oct 12, 2023 •
edited
Loading

Description

Closes #2342.

Keep this issue open, there are issue references in the code.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/feature Some user-visible feature is not implemented yet label Oct 12, 2023
@chilagrow chilagrow added this to the Next milestone Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #3566 (5f61b05) into main (90415f4) will decrease coverage by 0.44%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3566      +/-   ##
==========================================
- Coverage   61.45%   61.01%   -0.44%     
==========================================
  Files         426      426              
  Lines       27208    27225      +17     
==========================================
- Hits        16720    16611     -109     
- Misses       9498     9609     +111     
- Partials      990     1005      +15
Files Coverage Δ
internal/backends/backend.go 92.59% <ø> (ø)
internal/handlers/sqlite/msg_serverstatus.go 76.00% <100.00%> (ø)
internal/backends/postgresql/backend.go 54.44% <25.00%> (-2.88%) ⬇️
internal/backends/sqlite/backend.go 63.38% <33.33%> (-4.37%) ⬇️

... and 12 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.51% <33.33%> (-0.47%) ⬇️
hana-1 ?
integration 57.51% <33.33%> (-0.47%) ⬇️
mongodb-1 4.50% <0.00%> (-0.01%) ⬇️
postgresql-1 41.01% <5.55%> (-0.12%) ⬇️
postgresql-2 40.77% <16.66%> (-0.02%) ⬇️
postgresql-3 39.60% <16.66%> (+0.05%) ⬆️
sort-false 57.51% <33.33%> (-0.47%) ⬇️
sqlite-1 ?
sqlite-2 41.30% <22.22%> (-0.01%) ⬇️
sqlite-3 39.51% <22.22%> (+0.01%) ⬆️
unit 22.36% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review October 12, 2023 08:23
@chilagrow chilagrow requested review from AlekSi and a team as code owners October 12, 2023 08:23
@chilagrow chilagrow requested review from rumyantseva, a team and noisersup October 12, 2023 08:23
@chilagrow chilagrow enabled auto-merge (squash) October 12, 2023 08:23
AlekSi
AlekSi reviewed Oct 12, 2023
View reviewed changes
integration/commands_administration_test.go Outdated Show resolved Hide resolved
internal/backends/postgresql/backend.go Outdated Show resolved Hide resolved
@chilagrow chilagrow requested a review from AlekSi October 13, 2023 02:21
rumyantseva
rumyantseva approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow merged commit ce4945d into FerretDB:main Oct 13, 2023
25 of 26 checks passed
@AlekSi AlekSi changed the title Add capped collection counts in ServerStatus Add capped collection counts in serverStatus Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Implement missing fields for storageStats in $collStats aggregation pipeline stage
3 participants
@chilagrow @AlekSi @rumyantseva