Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests and fixes for $collStats aggregation stage #3565

Merged
merged 7 commits into from
Oct 13, 2023
Merged

Add more tests and fixes for $collStats aggregation stage #3565

merged 7 commits into from
Oct 13, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Oct 12, 2023 •
edited
Loading

Description

Closes #2349.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow changed the title Add more tests to $collStats Add more tests for $collStats aggregation stage Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #3565 (fc2cf2e) into main (30a1c91) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3565      +/-   ##
==========================================
- Coverage   61.43%   61.33%   -0.11%     
==========================================
  Files         426      426              
  Lines       27207    27208       +1     
==========================================
- Hits        16715    16687      -28     
- Misses       9502     9529      +27     
- Partials      990      992       +2
Files Coverage Δ
...l/handlers/common/aggregations/stages/collstats.go 85.93% <100.00%> (+0.69%) ⬆️
internal/handlers/commonerrors/error.go 88.23% <ø> (ø)
internal/handlers/commonerrors/errorcode_string.go 80.00% <ø> (ø)
internal/handlers/sqlite/msg_aggregate.go 89.09% <ø> (+2.71%) ⬆️

... and 5 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.85% <100.00%> (-0.10%) ⬇️
hana-1 ?
integration 57.85% <100.00%> (-0.10%) ⬇️
mongodb-1 4.51% <0.00%> (-0.01%) ⬇️
postgresql-1 41.13% <100.00%> (+<0.01%) ⬆️
postgresql-2 40.78% <75.00%> (+0.12%) ⬆️
postgresql-3 39.53% <0.00%> (-0.01%) ⬇️
sort-false 57.85% <100.00%> (-0.10%) ⬇️
sqlite-1 41.04% <100.00%> (+<0.01%) ⬆️
sqlite-2 41.31% <75.00%> (+0.12%) ⬆️
sqlite-3 39.45% <0.00%> (-0.01%) ⬇️
unit 22.38% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Oct 12, 2023
@chilagrow chilagrow added this to the Next milestone Oct 12, 2023
@chilagrow chilagrow changed the title Add more tests for $collStats aggregation stage Add more tests and fix bugs for $collStats aggregation stage Oct 12, 2023
@chilagrow chilagrow mentioned this pull request Oct 12, 2023
Merged
9 tasks
@chilagrow chilagrow marked this pull request as ready for review October 12, 2023 06:45
@chilagrow chilagrow requested a review from a team as a code owner October 12, 2023 06:45
@chilagrow chilagrow enabled auto-merge (squash) October 12, 2023 06:45
@chilagrow chilagrow changed the title Add more tests and fix bugs for $collStats aggregation stage Add more tests and fixes for $collStats aggregation stage Oct 12, 2023
@chilagrow chilagrow requested review from a team and noisersup October 12, 2023 06:45
@chilagrow chilagrow merged commit 90415f4 into FerretDB:main Oct 13, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Add more tests for $collStats aggregation stage
3 participants
@chilagrow @AlekSi @noisersup