Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call ANALYZE less often #3563

Merged
merged 41 commits into from
Oct 19, 2023
Merged

Call ANALYZE less often #3563

merged 41 commits into from
Oct 19, 2023

Conversation

Aditya1404Sal
Copy link
Contributor

@Aditya1404Sal Aditya1404Sal commented Oct 12, 2023 •
edited by chilagrow
Loading

Description

Currently i've made changes to the postgreSql and sqlite backend , I need help to make changes to ANALYZE to call on a given list of collection

Closes #3518.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #3563 (3cbb233) into main (9a56544) will decrease coverage by 0.61%.
The diff coverage is 74.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3563      +/-   ##
==========================================
- Coverage   62.20%   61.60%   -0.61%     
==========================================
  Files         426      426              
  Lines       27584    27649      +65     
==========================================
- Hits        17159    17032     -127     
- Misses       9424     9603     +179     
- Partials     1001     1014      +13
Files Coverage Δ
internal/backends/collection.go 100.00% <ø> (ø)
internal/backends/database.go 97.26% <ø> (ø)
internal/backends/postgresql/collection.go 64.56% <100.00%> (-4.62%) ⬇️
internal/backends/postgresql/database.go 71.69% <100.00%> (+0.82%) ⬆️
internal/backends/sqlite/collection.go 79.94% <100.00%> (ø)
internal/backends/sqlite/database.go 77.17% <100.00%> (+0.76%) ⬆️
internal/handlers/sqlite/msg_collstats.go 68.14% <100.00%> (ø)
internal/handlers/sqlite/msg_dbstats.go 69.64% <100.00%> (ø)
internal/backends/sqlite/sqlite.go 77.50% <78.57%> (+2.15%) ⬆️
internal/backends/postgresql/postgresql.go 78.04% <66.66%> (+1.12%) ⬆️
... and 1 more

... and 13 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 58.19% <70.78%> (-0.62%) ⬇️
hana-1 ?
integration 58.19% <70.78%> (-0.64%) ⬇️
mongodb-1 4.48% <0.00%> (-0.02%) ⬇️
postgresql-1 42.37% <47.19%> (-0.36%) ⬇️
postgresql-2 39.87% <47.19%> (-0.15%) ⬇️
postgresql-3 42.02% <56.17%> (-0.14%) ⬇️
sort-false 58.19% <70.78%> (-0.22%) ⬇️
sort-true ?
sqlite-1 42.24% <47.19%> (-0.18%) ⬇️
sqlite-2 39.34% <47.19%> (-0.03%) ⬇️
sqlite-3 41.48% <56.17%> (-0.41%) ⬇️
unit 22.66% <25.84%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

AlekSi
AlekSi requested changes Oct 12, 2023
View reviewed changes
internal/backends/postgresql/backend.go Outdated Show resolved Hide resolved
internal/backends/postgresql/collection.go Outdated Show resolved Hide resolved
internal/backends/postgresql/collection.go Outdated Show resolved Hide resolved
@Aditya1404Sal Aditya1404Sal requested a review from AlekSi October 13, 2023 14:13
AlekSi
AlekSi reviewed Oct 13, 2023
View reviewed changes
internal/backends/postgresql/database.go Outdated Show resolved Hide resolved
internal/backends/postgresql/postgresql.go Outdated Show resolved Hide resolved
internal/backends/postgresql/postgresql.go Outdated Show resolved Hide resolved
@AlekSi AlekSi changed the title Call ANALYZE less Call ANALYZE less often Oct 13, 2023
@chilagrow chilagrow requested a review from a team as a code owner October 18, 2023 09:08
@chilagrow chilagrow self-requested a review October 18, 2023 09:08
@chilagrow chilagrow added the code/chore Code maintenance improvements label Oct 18, 2023
@chilagrow chilagrow added this to the Next milestone Oct 18, 2023
chilagrow
chilagrow previously approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I push commits for minor cleanup 🤗

@chilagrow chilagrow requested review from a team, rumyantseva and noisersup October 18, 2023 09:38
@chilagrow chilagrow enabled auto-merge (squash) October 18, 2023 09:39
@AlekSi AlekSi self-requested a review October 18, 2023 10:17
@AlekSi AlekSi disabled auto-merge October 18, 2023 10:18
@AlekSi AlekSi enabled auto-merge (squash) October 18, 2023 10:18
@chilagrow chilagrow requested a review from AlekSi October 19, 2023 04:47
@AlekSi AlekSi requested a review from chilagrow October 19, 2023 05:44
@AlekSi AlekSi merged commit 384c284 into FerretDB:main Oct 19, 2023
27 checks passed
@Aditya1404Sal Aditya1404Sal deleted the firstIteration branch October 19, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@Aditya1404Sal Aditya1404Sal

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Call ANALYZE less often
3 participants
@Aditya1404Sal @AlekSi @chilagrow