Implement compact command
#3559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/compact-command
…t/compact-command
|
@adetunjii any news? Anything we could help you with? Also, could we add a basic integration test? |
|
@AlekSi Yh sure. I'd raise a PR today. Been really busy, sorry |
|
👋 @adetunjii I added basic integration tests to the implemented feature 🤗 |
chilagrow
force-pushed
the
feat/compact-command
branch
from
842df93 to
7824e1a
Compare
chilagrow
approved these changes
Oct 24, 2023
|
@chilagrow Thanks. I'll just pull the changes and resolve the conflicts on my end. I'd already worked on the fixes |
|
@adetunjii I think the PR is good enough already. If you want to change something, please do so today; we are going to merge that PR tomorrow. |
|
No. I’m not adding anything. Looks good to me. Thanks
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Alexey Palazhchenko ***@***.***>
Sent: Tuesday, October 24, 2023 9:30:26 AM
To: FerretDB/FerretDB ***@***.***>
Cc: Teej4y ***@***.***>; Mention ***@***.***>
Subject: Re: [FerretDB/FerretDB] Implement `compact` command (PR #3559)
@adetunjii<https://github.com/adetunjii> I think the PR is good enough already. If you want to change something, please do so today; we are going to merge that PR tomorrow.
—
Reply to this email directly, view it on GitHub<#3559 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKXTHW2DY5SUOBPFOCBY4QLYA54CFAVCNFSM6AAAAAA534IEISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZWG42TQMBYGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
AlekSi
approved these changes
Oct 24, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3466.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.