Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate PostgreSQL databases in tests #3553

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Use separate PostgreSQL databases in tests #3553

merged 7 commits into from
Oct 11, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 11, 2023 •
edited
Loading

Description

Do the same thing for PostgreSQL as we do for SQLite.

Also, remove some old tests.

Closes #3409.
(but I will re-open it to take another look)

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 11, 2023
@AlekSi AlekSi added this to the Next milestone Oct 11, 2023
@AlekSi AlekSi self-assigned this Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Merging #3553 (e209197) into main (9475382) will decrease coverage by 0.37%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3553      +/-   ##
==========================================
- Coverage   74.99%   74.63%   -0.37%     
==========================================
  Files         427      426       -1     
  Lines       27131    27162      +31     
==========================================
- Hits        20347    20271      -76     
- Misses       5572     5674     +102     
- Partials     1212     1217       +5
Files Coverage Δ
integration/setup/client.go 77.77% <ø> (ø)
...ternal/backends/postgresql/metadata/pool/opendb.go 56.94% <ø> (ø)
internal/backends/postgresql/metadata/registry.go 70.46% <100.00%> (-1.79%) ⬇️
internal/util/testutil/db.go 90.32% <90.47%> (-0.16%) ⬇️
integration/setup/listener.go 77.19% <91.11%> (+0.43%) ⬆️

... and 14 files with indirect coverage changes

Flag Coverage Δ
filter-true 71.46% <91.66%> (-0.37%) ⬇️
hana-1 ?
integration 71.46% <91.66%> (-0.37%) ⬇️
mongodb-1 4.51% <1.38%> (-0.01%) ⬇️
pg-1 42.67% <81.94%> (+0.17%) ⬆️
pg-2 40.11% <81.94%> (+0.18%) ⬆️
pg-3 41.71% <81.94%> (+0.08%) ⬆️
postgresql-1 41.45% <90.27%> (-0.25%) ⬇️
postgresql-2 38.88% <90.27%> (-0.23%) ⬇️
postgresql-3 41.29% <90.27%> (-0.20%) ⬇️
sort-false 71.46% <91.66%> (-0.37%) ⬇️
sqlite-1 41.89% <30.55%> (+0.02%) ⬆️
sqlite-2 39.13% <30.55%> (+0.02%) ⬆️
sqlite-3 40.99% <30.55%> (+0.02%) ⬆️
unit 22.32% <25.92%> (-3.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review October 11, 2023 07:52
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners October 11, 2023 07:52
@AlekSi AlekSi enabled auto-merge (squash) October 11, 2023 07:52
@AlekSi AlekSi requested review from a team and noisersup October 11, 2023 07:52
chilagrow
chilagrow approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

rumyantseva
rumyantseva approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

noisersup
noisersup approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi disabled auto-merge October 11, 2023 12:06
@AlekSi AlekSi merged commit 44ee460 into FerretDB:main Oct 11, 2023
31 checks passed
@AlekSi AlekSi deleted the separate-databases branch October 11, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Some backend tests are fluky
4 participants
@AlekSi @rumyantseva @chilagrow @noisersup