Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix explain panic for non-existent collection on PostgreSQL #3541

Merged
merged 10 commits into from
Oct 13, 2023
Merged

Fix explain panic for non-existent collection on PostgreSQL #3541

merged 10 commits into from
Oct 13, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Oct 10, 2023 •
edited
Loading

Description

Closes #3415.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #3541 (968f779) into main (1ea4ff4) will decrease coverage by 0.19%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3541      +/-   ##
==========================================
- Coverage   61.44%   61.26%   -0.19%     
==========================================
  Files         426      426              
  Lines       27187    27192       +5     
==========================================
- Hits        16706    16658      -48     
- Misses       9496     9542      +46     
- Partials      985      992       +7
Files Coverage Δ
internal/backends/collection.go 91.66% <ø> (ø)
internal/backends/postgresql/collection.go 68.48% <45.45%> (+0.51%) ⬆️

... and 11 files with indirect coverage changes

Flag Coverage Δ
filter-true 57.81% <45.45%> (-0.13%) ⬇️
hana-1 ?
integration 57.81% <45.45%> (-0.13%) ⬇️
mongodb-1 4.51% <0.00%> (-0.01%) ⬇️
postgresql-1 40.99% <45.45%> (-0.44%) ⬇️
postgresql-2 40.63% <18.18%> (+1.75%) ⬆️
postgresql-3 39.52% <18.18%> (-1.63%) ⬇️
sort-false 57.81% <45.45%> (-0.13%) ⬇️
sqlite-1 41.03% <0.00%> (-0.84%) ⬇️
sqlite-2 41.19% <0.00%> (+2.05%) ⬆️
sqlite-3 39.46% <0.00%> (-1.50%) ⬇️
unit 22.34% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup marked this pull request as ready for review October 11, 2023 14:04
@noisersup noisersup requested review from AlekSi and a team as code owners October 11, 2023 14:04
@noisersup noisersup requested review from chilagrow, a team and rumyantseva October 11, 2023 14:04
@noisersup noisersup changed the title Fix explain panic for non-existent collection on postgresql Fix explain panic for non-existent collection on PostgreSQL Oct 11, 2023
@noisersup noisersup enabled auto-merge (squash) October 11, 2023 14:42
AlekSi
AlekSi reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conform-pr fails.

(for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.

That item is checked but not done.

@noisersup noisersup added the code/bug Some user-visible feature works incorrectly label Oct 11, 2023
@noisersup noisersup requested a review from AlekSi October 11, 2023 19:35
@noisersup noisersup added this to the Next milestone Oct 11, 2023
@AlekSi AlekSi requested review from chilagrow and a team October 12, 2023 15:18
@noisersup noisersup merged commit f748ba9 into FerretDB:main Oct 13, 2023
26 of 27 checks passed
@noisersup noisersup deleted the fix-explain-panic branch October 13, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

Assignees

@noisersup noisersup

Labels
code/bug Some user-visible feature works incorrectly
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Implement sort pushdown
3 participants
@noisersup @AlekSi @chilagrow