Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Collection.Compact for SQLite #3536

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Implement Collection.Compact for SQLite #3536

merged 4 commits into from
Oct 11, 2023

Conversation

Akhil-2001
Copy link
Contributor

@Akhil-2001 Akhil-2001 commented Oct 9, 2023 •
edited by AlekSi
Loading

Description

Closes #3469.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@Akhil-2001 Akhil-2001 requested a review from AlekSi as a code owner October 9, 2023 16:30
@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #3536 (277965e) into main (57e283c) will decrease coverage by 1.90%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3536      +/-   ##
==========================================
- Coverage   74.85%   72.95%   -1.90%     
==========================================
  Files         426      426              
  Lines       27162    27184      +22     
==========================================
- Hits        20331    19832     -499     
- Misses       5624     6111     +487     
- Partials     1207     1241      +34
Files Coverage Δ
internal/backends/sqlite/collection.go 72.09% <0.00%> (-6.77%) ⬇️

... and 35 files with indirect coverage changes

Flag Coverage Δ
filter-true 69.76% <0.00%> (-1.88%) ⬇️
hana-1 ?
integration 69.76% <0.00%> (-1.88%) ⬇️
mongodb-1 4.51% <0.00%> (-0.01%) ⬇️
pg-1 42.64% <0.00%> (-0.04%) ⬇️
pg-2 40.08% <0.00%> (-0.04%) ⬇️
pg-3 ?
postgresql-1 41.42% <0.00%> (-0.04%) ⬇️
postgresql-2 38.86% <0.00%> (-0.03%) ⬇️
postgresql-3 41.25% <0.00%> (-0.09%) ⬇️
sort-false 69.76% <0.00%> (-1.88%) ⬇️
sqlite-1 41.86% <0.00%> (-0.04%) ⬇️
sqlite-2 39.10% <0.00%> (-0.07%) ⬇️
sqlite-3 ?
unit 22.30% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi self-assigned this Oct 10, 2023
@AlekSi AlekSi added this to the Next milestone Oct 11, 2023
@AlekSi AlekSi enabled auto-merge (squash) October 11, 2023 11:40
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup October 11, 2023 11:41
noisersup
noisersup approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Looks good to me.

@AlekSi AlekSi merged commit 2d57d3f into FerretDB:main Oct 11, 2023
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

@Akhil-2001 Akhil-2001

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Implement Collection.Compact for SQLite
3 participants
@Akhil-2001 @AlekSi @noisersup