Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info about indexes to dbStats response #3534

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Add info about indexes to dbStats response #3534

merged 3 commits into from
Oct 10, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Oct 9, 2023 •
edited
Loading

Description

Closes #3394.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Oct 9, 2023
@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Oct 9, 2023
@rumyantseva rumyantseva added this to the Next milestone Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #3534 (22a4788) into main (7db2372) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3534      +/-   ##
==========================================
- Coverage   75.04%   74.89%   -0.16%     
==========================================
  Files         427      427              
  Lines       27131    27130       -1     
==========================================
- Hits        20361    20319      -42     
- Misses       5561     5601      +40     
- Partials     1209     1210       +1
Files Coverage Δ
internal/backends/postgresql/postgresql.go 76.92% <100.00%> (-0.58%) ⬇️

... and 10 files with indirect coverage changes

Flag Coverage Δ
filter-true 71.69% <100.00%> (-0.19%) ⬇️
hana-1 ?
integration 71.69% <100.00%> (-0.19%) ⬇️
mongodb-1 4.52% <0.00%> (+<0.01%) ⬆️
pg-1 42.49% <0.00%> (+<0.01%) ⬆️
pg-2 39.92% <0.00%> (-0.03%) ⬇️
pg-3 41.62% <0.00%> (+<0.01%) ⬆️
postgresql-1 41.69% <100.00%> (-0.02%) ⬇️
postgresql-2 39.13% <100.00%> (-0.01%) ⬇️
postgresql-3 41.51% <100.00%> (+0.07%) ⬆️
sort-false 71.69% <100.00%> (-0.19%) ⬇️
sqlite-1 41.86% <0.00%> (-0.01%) ⬇️
sqlite-2 39.09% <0.00%> (-0.01%) ⬇️
sqlite-3 40.92% <0.00%> (-0.05%) ⬇️
unit 25.95% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva requested review from a team, chilagrow and noisersup October 9, 2023 15:30
@rumyantseva rumyantseva marked this pull request as ready for review October 9, 2023 15:30
@rumyantseva rumyantseva requested a review from AlekSi as a code owner October 9, 2023 15:30
@rumyantseva rumyantseva enabled auto-merge (squash) October 9, 2023 15:30
@AlekSi AlekSi added code/feature Some user-visible feature is not implemented yet and removed code/chore Code maintenance improvements labels Oct 9, 2023
@AlekSi AlekSi modified the milestones: Next, v1.12.0 Oct 9, 2023
chilagrow
chilagrow approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@rumyantseva rumyantseva merged commit 313f948 into FerretDB:main Oct 10, 2023
29 checks passed
@rumyantseva rumyantseva deleted the issue-3394-list-indexes branch October 10, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@rumyantseva rumyantseva

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.

Implement ListIndexes
3 participants
@rumyantseva @AlekSi @chilagrow