Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests for indexes #3531

Merged
merged 7 commits into from
Oct 9, 2023
Merged

Fix unit tests for indexes #3531

merged 7 commits into from
Oct 9, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Oct 9, 2023 •
edited
Loading

Description

Closes #3375.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Oct 9, 2023
@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Oct 9, 2023
@rumyantseva rumyantseva added this to the Next milestone Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #3531 (f391337) into main (fb13096) will decrease coverage by 8.31%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3531      +/-   ##
==========================================
- Coverage   75.09%   66.78%   -8.31%     
==========================================
  Files         427      427              
  Lines       27119    27122       +3     
==========================================
- Hits        20364    18114    -2250     
- Misses       5551     7733    +2182     
- Partials     1204     1275      +71
Files Coverage Δ
internal/backends/postgresql/postgresql.go 77.50% <0.00%> (-6.29%) ⬇️

... and 87 files with indirect coverage changes

Flag Coverage Δ
filter-true 60.12% <0.00%> (-11.88%) ⬇️
hana-1 ?
integration 60.12% <0.00%> (-11.88%) ⬇️
mongodb-1 4.50% <0.00%> (-0.01%) ⬇️
pg-1 38.94% <0.00%> (-0.01%) ⬇️
pg-2 ?
pg-3 42.39% <0.00%> (-0.01%) ⬇️
postgresql-1 ?
postgresql-2 ?
postgresql-3 ?
sort-false 60.12% <0.00%> (-11.88%) ⬇️
sqlite-1 38.11% <0.00%> (-0.02%) ⬇️
sqlite-2 ?
sqlite-3 41.84% <0.00%> (-0.01%) ⬇️
unit 25.91% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva marked this pull request as ready for review October 9, 2023 15:07
@rumyantseva rumyantseva requested a review from AlekSi as a code owner October 9, 2023 15:07
@rumyantseva rumyantseva enabled auto-merge (squash) October 9, 2023 15:07
@rumyantseva rumyantseva requested review from a team, chilagrow and noisersup October 9, 2023 15:08
noisersup
noisersup approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlekSi AlekSi modified the milestones: Next, v1.12.0 Oct 9, 2023
@rumyantseva rumyantseva merged commit b932d0f into FerretDB:main Oct 9, 2023
23 of 28 checks passed
@rumyantseva rumyantseva deleted the fix-flaky-tests branch October 9, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.

Store index metadata
3 participants
@rumyantseva @AlekSi @noisersup