Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation #3530

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Update documentation #3530

merged 7 commits into from
Oct 10, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 9, 2023 •
edited
Loading

Description

Mention the new PostgreSQL backend.
Tweak internal docs.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Oct 9, 2023
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Oct 9, 2023
@AlekSi AlekSi changed the title Tweak labels Update documentation Oct 9, 2023
@AlekSi AlekSi added this to the v1.12.0 milestone Oct 9, 2023
@AlekSi AlekSi added documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Oct 9, 2023
@AlekSi AlekSi added the do not merge PRs that should not be merged label Oct 9, 2023
@AlekSi AlekSi marked this pull request as ready for review October 9, 2023 16:49
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners October 9, 2023 16:49
@AlekSi AlekSi enabled auto-merge (squash) October 9, 2023 16:49
@AlekSi AlekSi requested review from a team, noisersup and Fashander October 9, 2023 16:49
noisersup
noisersup approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, LGTM

@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #3530 (6e524a4) into main (313f948) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3530      +/-   ##
==========================================
- Coverage   75.01%   75.00%   -0.02%     
==========================================
  Files         427      427              
  Lines       27130    27131       +1     
==========================================
- Hits        20352    20349       -3     
- Misses       5570     5573       +3     
- Partials     1208     1209       +1
Files Coverage Δ
internal/clientconn/listener.go 75.35% <100.00%> (+0.11%) ⬆️

... and 1 file with indirect coverage changes

Flag Coverage Δ
filter-true 71.82% <100.00%> (+0.01%) ⬆️
hana-1 2.89% <0.00%> (-0.01%) ⬇️
integration 71.82% <100.00%> (+0.01%) ⬆️
mongodb-1 4.52% <0.00%> (-0.01%) ⬇️
pg-1 42.49% <100.00%> (+<0.01%) ⬆️
pg-2 39.93% <100.00%> (+<0.01%) ⬆️
pg-3 41.62% <100.00%> (+0.09%) ⬆️
postgresql-1 41.69% <100.00%> (-0.01%) ⬇️
postgresql-2 39.14% <100.00%> (+0.01%) ⬆️
postgresql-3 41.51% <100.00%> (+<0.01%) ⬆️
sort-false 71.82% <100.00%> (+0.01%) ⬆️
sqlite-1 41.87% <100.00%> (+<0.01%) ⬆️
sqlite-2 39.13% <100.00%> (+<0.01%) ⬆️
sqlite-3 40.93% <100.00%> (+<0.01%) ⬆️
unit 25.92% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi requested a review from b1ron October 10, 2023 09:33
b1ron
b1ron approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@b1ron b1ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test scripts section LGTM.

@AlekSi AlekSi removed the do not merge PRs that should not be merged label Oct 10, 2023
@AlekSi AlekSi disabled auto-merge October 10, 2023 10:27
@AlekSi AlekSi merged commit 99c646b into FerretDB:main Oct 10, 2023
50 of 53 checks passed
@AlekSi AlekSi deleted the docs branch October 10, 2023 10:27
rumyantseva
rumyantseva approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1ron b1ron b1ron approved these changes

@noisersup noisersup noisersup approved these changes

@Fashander Fashander Fashander approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

Assignees

@AlekSi AlekSi

Labels
documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.
6 participants
@AlekSi @rumyantseva @chilagrow @Fashander @noisersup @b1ron