Move diff tests from dance to integration tests #3525
Conversation
|
|
Signed-off-by: Shankeerthan Kasilingam <shankeerthan1995@gmail.com>
|
Hi @AlekSi, |
integration/helpers.go
Outdated
| // unsetRaw returns error with all Raw fields unset. It returns nil if err is nil. | ||
| // | ||
| // Error is checked using a regular type assertion; wrapped errors (errors.As) are not checked. | ||
| func unsetRaw(t testing.TB, err error) error { |
There was a problem hiding this comment.
That should be replaced with an existing UnsetRaw function
integration/helpers.go
Outdated
| } | ||
|
|
||
| // assertEqualError asserts that the expected error is the same as the actual (ignoring the Raw part). | ||
| func assertEqualError(t testing.TB, expected mongo.CommandError, actual error) bool { |
There was a problem hiding this comment.
That should be replaces with existing AssertEqualCommandError
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3525 +/- ##
==========================================
+ Coverage 76.34% 76.40% +0.05%
==========================================
Files 323 323
Lines 23069 23069
==========================================
+ Hits 17613 17625 +12
+ Misses 4417 4406 -11
+ Partials 1039 1038 -1 see 16 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@ksankeerth any news? Anything we could help you with? |
chilagrow
changed the title
integration/basic_test.go
Outdated
| Message: "ErrorCode(33333)", | ||
| }, | ||
| }, | ||
| // TODO https://github.com/FerretDB/FerretDB/issues/3672 |
There was a problem hiding this comment.
Created a new issue in FerretDB because issue link for dance fails on todo linter check 🙈
|
Thank you! |
Description
Closes #3383.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.