Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make new PostgreSQL backend tests pass #3522

Merged
merged 15 commits into from
Oct 9, 2023
Merged

Make new PostgreSQL backend tests pass #3522

merged 15 commits into from
Oct 9, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Oct 7, 2023 •
edited
Loading

Description

After or insted of #3511.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Oct 7, 2023 •
edited
Loading

Codecov Report

Merging #3522 (afedba0) into main (be0f7b6) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3522      +/-   ##
==========================================
- Coverage   75.04%   74.86%   -0.18%     
==========================================
  Files         427      427              
  Lines       27124    27131       +7     
==========================================
- Hits        20354    20312      -42     
- Misses       5565     5607      +42     
- Partials     1205     1212       +7
Files Coverage Δ
integration/setup/client.go 77.77% <ø> (-12.23%) ⬇️
integration/setup/test_helpers.go 100.00% <100.00%> (ø)

... and 21 files with indirect coverage changes

Flag Coverage Δ
filter-true 71.67% <100.00%> (-0.33%) ⬇️
hana-1 ?
integration 71.67% <100.00%> (-0.33%) ⬇️
mongodb-1 4.52% <50.00%> (+0.01%) ⬆️
pg-1 42.49% <50.00%> (+<0.01%) ⬆️
pg-2 39.92% <50.00%> (+<0.01%) ⬆️
pg-3 41.52% <50.00%> (-0.12%) ⬇️
postgresql-1 41.68% <100.00%> (-1.00%) ⬇️
postgresql-2 39.13% <100.00%> (+0.68%) ⬆️
postgresql-3 41.51% <100.00%> (+0.09%) ⬆️
sort-false 71.67% <100.00%> (-0.33%) ⬇️
sqlite-1 41.87% <50.00%> (+<0.01%) ⬆️
sqlite-2 39.10% <50.00%> (-0.03%) ⬇️
sqlite-3 40.83% <50.00%> (-0.17%) ⬇️
unit 25.95% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva changed the title Todos for tests Make tests for new PG backend pass Oct 9, 2023
@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Oct 9, 2023
@rumyantseva rumyantseva changed the title Make tests for new PG backend pass Make new PostgreSQL backend tests pass Oct 9, 2023
@rumyantseva rumyantseva added this to the Next milestone Oct 9, 2023
@rumyantseva rumyantseva marked this pull request as ready for review October 9, 2023 08:35
@rumyantseva rumyantseva requested review from AlekSi and a team as code owners October 9, 2023 08:35
@rumyantseva rumyantseva requested a review from chilagrow October 9, 2023 08:35
@rumyantseva rumyantseva enabled auto-merge (squash) October 9, 2023 08:35
@rumyantseva rumyantseva requested review from a team and noisersup October 9, 2023 08:35
noisersup
noisersup previously approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart minor comments above LGTM

@AlekSi AlekSi disabled auto-merge October 9, 2023 19:19
@AlekSi AlekSi modified the milestones: Next, v1.12.0 Oct 9, 2023
@AlekSi AlekSi merged commit 7db2372 into FerretDB:main Oct 9, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@rumyantseva @AlekSi @noisersup