Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Ping for checking connection #3519

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Use Ping for checking connection #3519

merged 1 commit into from
Oct 7, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 7, 2023 •
edited
Loading

Description

Refs #3518.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Oct 7, 2023
@codecov
Copy link

codecov bot commented Oct 7, 2023 •
edited
Loading

Codecov Report

Merging #3519 (63a38b3) into main (50fc27d) will decrease coverage by 1.52%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3519      +/-   ##
==========================================
- Coverage   74.96%   73.44%   -1.52%     
==========================================
  Files         426      426              
  Lines       26969    26966       -3     
==========================================
- Hits        20216    19804     -412     
- Misses       5565     5968     +403     
- Partials     1188     1194       +6
Files Coverage Δ
internal/backends/collection.go 91.66% <ø> (ø)
internal/backends/database.go 94.20% <ø> (ø)
internal/backends/postgresql/postgresql.go 83.78% <100.00%> (-0.43%) ⬇️
internal/backends/sqlite/sqlite.go 80.32% <100.00%> (-0.32%) ⬇️
integration/setup/client.go 70.00% <0.00%> (-0.97%) ⬇️

... and 29 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 67.48% <14.28%> (-4.21%) ⬇️
hana-1 ?
integration 67.48% <14.28%> (-4.26%) ⬇️
mongodb-1 4.53% <0.00%> (-0.01%) ⬇️
pg-1 39.17% <0.00%> (-0.51%) ⬇️
pg-2 42.26% <0.00%> (-0.50%) ⬇️
pg-3 42.64% <0.00%> (-0.70%) ⬇️
postgresql-1 ?
postgresql-2 ?
postgresql-3 ?
sort-false 67.48% <14.28%> (-3.68%) ⬇️
sort-true ?
sqlite-1 38.34% <14.28%> (-0.02%) ⬇️
sqlite-2 41.43% <14.28%> (-0.17%) ⬇️
sqlite-3 42.08% <14.28%> (-0.10%) ⬇️
unit 25.66% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 7, 2023
@AlekSi AlekSi added this to the Next milestone Oct 7, 2023
@AlekSi AlekSi marked this pull request as ready for review October 7, 2023 05:00
@AlekSi AlekSi requested a review from a team as a code owner October 7, 2023 05:00
@AlekSi AlekSi merged commit 3502cc0 into FerretDB:main Oct 7, 2023
25 of 34 checks passed
@AlekSi AlekSi deleted the ping-todos branch October 7, 2023 05:01
@rumyantseva
Copy link
Contributor

@AlekSi ping is not any better! It calls Status under the hood, and Status calls DatabaseList again.

@AlekSi
Copy link
Member Author

AlekSi commented Oct 7, 2023

Ping/Status is better because it is documented for that purpose.

And the referenced issue is not closed.

@AlekSi AlekSi added code/enhancement Some user-visible feature could work better and removed code/chore Code maintenance improvements labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/enhancement Some user-visible feature could work better
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @rumyantseva